kjuulh/todo
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Update nextjs monorepo to v13.4.12 #136

Merged
kjuulh merged 1 commits from renovate/nextjs-monorepo into main 2023-07-25 00:55:57 +02:00
Conversation 0 Commits 1 Files Changed 2 +70 -70
kjuulh commented 2023-07-23 14:17:08 +02:00
Owner
Copy Link

This PR contains the following updates:

Package Type Update Change
eslint-config-next (source) devDependencies patch 13.4.8 -> 13.4.12
next (source) dependencies patch 13.4.8 -> 13.4.12

Release Notes

vercel/next.js

v13.4.12

Compare Source

Core Changes
  • Separate routing code from render servers: #​52492
  • Move Pages API rendering into bundle: #​52149
  • update Turbopack: #​52986
  • Turbopack: Refactoring module references: #​52930
  • Increase timeout for 404 tests: #​52998
  • Reland "Refine the not-found rendering process for app router": #​52985
  • Revert "Separate routing code from render servers (#​52492)": #​53016
Documentation Changes
  • "Clarify the 'Existing Projects' section of the TypeScript docs:: #​52944
  • Update 02-dynamic-routes.mdx: #​52975
  • chore(docs): fix broken link: #​53021
Misc Changes
  • Update to latest version of turborepo: #​52979
  • Update swc_core to v0.79.22: #​52945
  • chore(ci): add pnpm workspace for github actions: #​52976
  • Changed package manager for install-native.mjs to pnpm: #​52971
  • update CODEOWNERS config: #​53017
Credits

Huge thanks to @​ijjk, @​wyattjoh, @​sokra, @​kdy1, @​alexkirsz, @​styfle, @​ShaunFerris, @​syedtaqi95, @​Heidar-An, @​huozhi, and @​ztanner for helping!

v13.4.11

Compare Source

Core Changes
  • fix: add missing <preload> for next/image in App Router: #​52425
  • Support metadata exports for server components not-found: #​52678
  • feat(next-swc): try to fallback native bindings with MODULE_NOT_FOUND: #​52667
  • Turbopack: Vc and Turbo Engine type system improvements : #​51792
  • Fix runtime edge not-found handling: #​52754
  • fix: forward NavigateOptions in adaptForAppRouterInstance: #​52498
  • fix(output): do not slice pathname unless ends with .txt: #​52640
  • Fix tagsManifest initialization check: #​52776
  • Turbopack: Experimental dev app pages support: #​52680
  • Turbopack: move Asset::ident to more specific traits: #​52683
  • Fix tracking of ContextModule: #​52795
  • Set process.title for router and render workers: #​52779
  • fix Remove unnecessary await: #​52800
  • Revert "perf: improve URL validation performance": #​52818
  • Refactor the client entry plugin: #​52798
  • Turbopack: Add manifest generation to pages: #​52793
  • Turbopack: move references() to specific traits: #​52822
  • Update default moduleResolution in tsconfig.json from node to bundler: #​51957
  • Turbopack: Next.rs API improvements: #​52856
  • update turbopack: #​52899
  • Update vendor @​vercel/og: #​52897
  • Fixed:#​52853 Lacking 'color' attribute in IconDescriptor Metadata: #​52902
  • Support basePath with edge runtime for Custom App Routes: #​52910
  • improve error DX on pages with RSC build errors: #​52843
  • fix: allow smooth scrolling if only hash changes (pages & app): #​52915
  • add edge support for next.rs API: #​52885
  • Allow general language codes in the Metadata API: #​52920
  • Fix client reference manifest for interception routes: #​52961
  • Refine the not-found rendering process for app router: #​52790
  • app-router: prefetching tweaks: #​52949
  • Revert "Refine the not-found rendering process for app router": #​52977
Documentation Changes
  • Update mention of route handlers for forms: #​52781
  • (Docs) add missing js version for generateMetadata.: #​52763
  • docs : fix typo in React cache example: #​52787
  • chore(docs): Add mentioning of HOSTNAME env variable for standalone output: #​52804
  • Fix typo in docs: #​52815
  • Update 02-edge-and-nodejs-runtimes.mdx: #​52888
  • chore(docs): add Typescript statically typed links mention in link doc: #​52847
  • chore(docs): fix typo in generate metadata docs: #​52904
  • fix example component in MDX documentation: #​52753
  • wrong content for next.config.mjs for MDX Plugins: #​52738
  • Update 06-lazy-loading.mdx: Incorrect filename in Example on "Importing Named Imports": #​52932
  • Change "publically" to "publicly" in the routing docs: #​52966
Example Changes
  • examples: export force-dynamic from all dynamic routes: #​52916
Misc Changes
  • chore: add "please simplify reproduction" comment: #​52631
  • update job concurrency: #​52788
  • Lock node version to 18.16: #​52894
  • Update runs-on tags
  • chore: add GitHub Action to manage "+1" comments: #​52866
Credits

Huge thanks to @​styfle, @​huozhi, @​balazsorban44, @​kwonoj, @​alexkirsz, @​ijjk, @​Jeffrey-Zutt, @​timneutkens, @​vinaykulk621, @​Ryan-Dia, @​sokra, @​shuding, @​steppefox, @​hiro0218, @​rjsdnql123, @​feedthejim, @​fgiuliani, @​steven-tey, @​AntoineBourin, @​adamrhunter, @​darshanjain-entrepreneur, @​s0h311, @​wyattjoh, @​ztanner, @​djreillo, @​dijonmusters, and @​cassidoo for helping!

v13.4.10

Compare Source

Core Changes
  • Fix trailing slash with locale domain: #​52343
  • perf: use fs.readdirSync with withFileTypes: #​52340
  • Make get_client_chunking_context independent of context: #​51928
  • perf: use fs.opendir for better resource usage: #​52341
  • fix: metadatabase warning message: #​52363
  • perf: simplify getShortDynamicParamType on app-render: #​52355
  • fix: prevent infinite dev refresh on nested parallel routes: #​52362
  • turbopack: add incremental cache for node.js app rendering: #​52172
  • Refactor metadata og and twitter title to be always presented: #​52320
  • perf: reduce system calls on eslint plugin: #​52359
  • Turbopack: Use a different chunking context for web entry: #​52404
  • Temporarily revert change to pages render: #​52407
  • Remove integration tests now in vercel/turbo: #​52413
  • Update Rust nightly toolchain: #​51757
  • Cache concurrent ensurePage requests for the same page: #​52360
  • [turbopack]: Remove skipped integration tests: #​52421
  • Fix metadata layer webpack rule for server-only: #​52403
  • Override file based images with social images property: #​52416
  • Split the client reference manifest file to be generated per-entry: #​52450
  • fix(standalone): fixed output: "standalone" crashing build when there is no app/ page: #​51993
  • fix: add aws packages to default serverComponentsExternalPackages: #​52388
  • refactor: avoid unnecessary async scopes in eslint: #​52418
  • Ensure useParams return array for catch-all routes: #​52494
  • turbopack: Module Trait: #​52401
  • Fix tracking of client reference manifest: #​52505
  • perf: create an experimental bundled version of the next server: #​52206
  • Chore: Remove redundant intersection type: #​52453
  • perf: Refactor recursiveReadDirSync: #​52517
  • add version to function config manifest: #​52507
  • Turbopack: Source trait: #​52511
  • Update id handling for fonts: #​52559
  • feat(turbopack): support swc transform plugins : #​50401
  • feat(babel-loader): provide migration help message for babel config: #​52565
  • Support global-error for ssr fallback: #​52573
  • Fix ISR case with bot requests: #​52581
  • fix(next/jest): jest can not load server-only code: #​52393
  • Turbopack: App Router build POC: #​52036
  • Avoid loading Next.js config again in render workers: #​52587
  • Add more extensions to next-types-plugin for Node16/NodeNext: #​52562
  • feat(next-swc): report native bindings load err code: #​52570
  • Move App Pages rendering into bundle: #​52290
  • feat(turbopack): support native webp: #​52285
  • Set sizes prop to any for svg icons: #​52609
  • Turbopack: OutputAsset trait: #​52606
  • chore(deps): bump react@18.3.0-canary-9377e1010-20230712: #​52649
  • Ensure root layout only render once per request: #​52589
  • Fix bundle path normalization for /index routes: #​52650
  • Turobpack: Next.rs API (part 1): #​52259
  • Clean up promises after resolving: #​52656
  • Catch layout error in global-error: #​52654
  • Fix per-entry client reference manifest for grouped and named segments: #​52664
Documentation Changes
  • chore(docs): fix link to useSearchParams: #​52348
  • docs: Clarify create-next-app requires public GitHub URLs.: #​52367
  • remove unnecessary dot.: #​52387
  • fix metadata-related typo in MDX documentation: #​52446
  • docs: Simplify message in React essentials section.: #​52469
  • docs: Improve error handling docs for server-side errors.: #​52302
  • docs: Add Playwright/Cypress Discord links: #​52084
  • docs: Add Kuma to CSS-in-JS supported list.: #​52438
  • docs: clarify fetch request de-duplication: #​52100
  • docs: Update TypeScript plugin section for VS Code prompt: #​52111
  • docs: Improve hydration mismatch error guide.: #​52481
  • docs: add Supabase loader for next/image: #​52480
  • docs: fix the incrementalCacheHandlerPath: #​52124
  • fixed error #​52486 fetchUsers to fetchUser: #​52487
  • Update 08-parallel-routes.mdx: #​52419
  • docs: Add formData example for Route Handlers: #​52358
  • chore(docs): Typesafe metadata object: #​52252
  • docs: Update _app and _document: #​52479
  • docs: add CDN optimization as possible hydration error cause: #​52489
  • docs: correct TypeScript spelling on the home page: #​52500
  • chore(docs): fix a few typos in image loader docs: #​52508
  • docs: fix grammar on Server Actions: #​52556
  • Fixed grammar in 03-react-essentials.mdx: #​52597
  • docs: fix typo in CSS Modules Description: #​52599
  • docs: Fix typo in generate-static-params.mdx: #​52595
  • docs: move MUI to supported list: #​52584
  • docs: Add missing closing tag for react hydration error message.: #​52607
Example Changes
  • examples: Update Convex to latest version (0.19): #​52473
  • Update examples: counter.tsx - Don't need empty space: #​52576
Misc Changes
  • Update swc_core to v0.79.13: #​52371
  • chore(ci): fix turbo input path globs: #​52414
  • fix(create-next-app): click event blockage under 1024px by adjusting z-index: #​52074
  • chore: add label to locked threads: #​52497
  • fix: not-found.tsx with output: export: #​52526
  • use npm pack instead of yarn pack: #​52563
  • ci: skip build-native for docs only change: #​52571
  • Remove unnecessary body-parser: #​52580
Credits

Huge thanks to @​ijjk, @​anonrig, @​alexkirsz, @​gfgabrielfranca, @​styfle, @​ztanner, @​leerob, @​sokra, @​huozhi, @​Bitbbot, @​wyattjoh, @​kdy1, @​wbinnssmith, @​shuding, @​jridgewell, @​BrennanColberg, @​Nick-Mazuk, @​delbaoliveira, @​thomasballinger, @​lucgagan, @​nroland013, @​SonMooSans, @​jenewland1999, @​thorwebdev, @​jyunhanlin, @​darshanjain-entrepreneur, @​DuCanhGH, @​Gnadhi, @​yagogmaisp, @​carlos-menezes, @​balazsorban44, @​ryo-manba, @​timneutkens, @​feedthejim, @​vamcs, @​matepapp, @​SleeplessOne1917, @​ecklf, @​djreillo, @​kwonoj, @​gnoff, @​feugy, @​karlhorky, @​starunaway, @​FernandVEYRIER, @​Ryan-Dia, @​Terro216, @​anthonyshew, and @​suhaotian for helping!

v13.4.9

Compare Source

Core Changes
  • Reland "ReverseTopological -> AdjacencyMap"": #​52142
  • Change the Server Actions feature flag to be validated at compile time: #​52147
  • Fix modularizeImports transform of antd: #​52148
  • fix: next.config.js with unstable_getImgProps(): #​52153
  • update tests list to include all passing tests: #​52026
  • Support scroll: false for Link component for app router: #​51869
  • Memoize useRouter from next/navigation when used in Pages Router: #​52177
  • chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630: #​52005
  • fix: infinite dev reloads when parallel route is treated a page entry: #​52061
  • disable flaky test cases: #​52184
  • Revert "chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630": #​52192
  • update turbopack: #​52186
  • Update CustomModuleType import: #​52133
  • Skip build-time dynamic code checks for specific polyfills in the Edge runtime: #​52009
  • Update Turbopack: #​52198
  • Use base36 for the RSC query: #​52204
  • Fix dynamicParams check in TS plugin: #​52211
  • Fix tree shaking for image generation module: #​51950
  • fix env reloading for turbopack: #​52194
  • Remove zod from require-hook: #​52197
  • Optimize watch ignore: #​52238
  • Remove the outdated error for find page dir: #​52274
  • Disable flakey turbopack env test: #​52295
  • skip hot reload sync event for applying hmr updates: #​52270
  • Handle 409s in fetch cache: #​51652
  • chore: remove experimental appDir: true from tests: #​52291
  • fix: correct modularizeImports for antd & ant-design/icons: #​52169
  • Update checksum algorithm to SHA1: #​52102
  • chore(deps): bump react to 7118f5d: #​52282
  • Update eslint-plugin-react-hooks to 5.0.0-canary-7118f5dd7-20230705: #​52275
  • Named page chunks: #​51921
  • chore: fix next dev turbopack benchmark: #​52328
  • Fix to use keep-alive in standalone mode: #​50221
  • Use 127.0.0.1 as the default host for the standalone server #​52283
Documentation Changes
  • Update generate-image-metadata.mdx: #​52230
  • docs(mdx): Add clearer instructions on the storage location of mdx-components files.: #​52187
  • docs: Improve some of the error messages pages.: #​52271
  • fix wrong Link import: #​52298
  • Document redirect parameters: #​51987
  • Add manual installation instructions for pages: #​51995
  • Update 10-router-handlers.mdx: #​52098
  • Add app router example: #​52066
  • doc: update typo in instrumentation page: #​52311
Example Changes
  • Remove legacy head.js in examples: #​52292
Misc Changes
  • Update test result step: #​52154
  • Update result job condition: #​52155
  • fix workflow needs: #​52180
  • chore: update issue template option to "App Router": #​52287
  • msic: disable otel esm test: #​52325
  • Test Progressive Enhancement of Server Actions: #​52062
  • fix(create-next-app): add missing metadata type: #​52299
Credits

Huge thanks to @​huozhi, @​shuding, @​ijjk, @​styfle, @​sokra, @​timneutkens, @​ztanner, @​alexkirsz, @​simonswiss, @​feikerwu, @​lubakravche, @​leerob, @​masnormen, @​bottxiang, @​acdlite, @​delbaoliveira, @​feedthejim, @​mhmdrioaf, @​tyler-lutz, @​sebmarkbage, @​vincenthongzy, @​yigithanyucedag, and @​doinki for helping!

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-config-next](https://nextjs.org/docs/app/building-your-application/configuring/eslint#eslint-config) ([source](https://github.com/vercel/next.js)) | devDependencies | patch | [`13.4.8` -> `13.4.12`](https://renovatebot.com/diffs/npm/eslint-config-next/13.4.8/13.4.12) | | [next](https://nextjs.org) ([source](https://github.com/vercel/next.js)) | dependencies | patch | [`13.4.8` -> `13.4.12`](https://renovatebot.com/diffs/npm/next/13.4.8/13.4.12) | --- ### Release Notes <details> <summary>vercel/next.js</summary> ### [`v13.4.12`](https://github.com/vercel/next.js/releases/tag/v13.4.12) [Compare Source](https://github.com/vercel/next.js/compare/v13.4.11...v13.4.12) ##### Core Changes - Separate routing code from render servers: [#&#8203;52492](https://github.com/vercel/next.js/issues/52492) - Move Pages API rendering into bundle: [#&#8203;52149](https://github.com/vercel/next.js/issues/52149) - update Turbopack: [#&#8203;52986](https://github.com/vercel/next.js/issues/52986) - Turbopack: Refactoring module references: [#&#8203;52930](https://github.com/vercel/next.js/issues/52930) - Increase timeout for 404 tests: [#&#8203;52998](https://github.com/vercel/next.js/issues/52998) - Reland "Refine the not-found rendering process for app router": [#&#8203;52985](https://github.com/vercel/next.js/issues/52985) - Revert "Separate routing code from render servers ([#&#8203;52492](https://github.com/vercel/next.js/issues/52492))": [#&#8203;53016](https://github.com/vercel/next.js/issues/53016) ##### Documentation Changes - "Clarify the 'Existing Projects' section of the TypeScript docs:: [#&#8203;52944](https://github.com/vercel/next.js/issues/52944) - Update 02-dynamic-routes.mdx: [#&#8203;52975](https://github.com/vercel/next.js/issues/52975) - chore(docs): fix broken link: [#&#8203;53021](https://github.com/vercel/next.js/issues/53021) ##### Misc Changes - Update to latest version of turborepo: [#&#8203;52979](https://github.com/vercel/next.js/issues/52979) - Update `swc_core` to `v0.79.22`: [#&#8203;52945](https://github.com/vercel/next.js/issues/52945) - chore(ci): add pnpm workspace for github actions: [#&#8203;52976](https://github.com/vercel/next.js/issues/52976) - Changed package manager for install-native.mjs to pnpm: [#&#8203;52971](https://github.com/vercel/next.js/issues/52971) - update CODEOWNERS config: [#&#8203;53017](https://github.com/vercel/next.js/issues/53017) ##### Credits Huge thanks to [@&#8203;ijjk](https://github.com/ijjk), [@&#8203;wyattjoh](https://github.com/wyattjoh), [@&#8203;sokra](https://github.com/sokra), [@&#8203;kdy1](https://github.com/kdy1), [@&#8203;alexkirsz](https://github.com/alexkirsz), [@&#8203;styfle](https://github.com/styfle), [@&#8203;ShaunFerris](https://github.com/ShaunFerris), [@&#8203;syedtaqi95](https://github.com/syedtaqi95), [@&#8203;Heidar-An](https://github.com/Heidar-An), [@&#8203;huozhi](https://github.com/huozhi), and [@&#8203;ztanner](https://github.com/ztanner) for helping! ### [`v13.4.11`](https://github.com/vercel/next.js/releases/tag/v13.4.11) [Compare Source](https://github.com/vercel/next.js/compare/v13.4.10...v13.4.11) ##### Core Changes - fix: add missing `<preload>` for `next/image` in App Router: [#&#8203;52425](https://github.com/vercel/next.js/issues/52425) - Support metadata exports for server components not-found: [#&#8203;52678](https://github.com/vercel/next.js/issues/52678) - feat(next-swc): try to fallback native bindings with MODULE_NOT_FOUND: [#&#8203;52667](https://github.com/vercel/next.js/issues/52667) - Turbopack: Vc<T> and Turbo Engine type system improvements : [#&#8203;51792](https://github.com/vercel/next.js/issues/51792) - Fix runtime edge not-found handling: [#&#8203;52754](https://github.com/vercel/next.js/issues/52754) - fix: forward NavigateOptions in adaptForAppRouterInstance: [#&#8203;52498](https://github.com/vercel/next.js/issues/52498) - fix(output): do not slice pathname unless ends with `.txt`: [#&#8203;52640](https://github.com/vercel/next.js/issues/52640) - Fix tagsManifest initialization check: [#&#8203;52776](https://github.com/vercel/next.js/issues/52776) - Turbopack: Experimental dev app pages support: [#&#8203;52680](https://github.com/vercel/next.js/issues/52680) - Turbopack: move Asset::ident to more specific traits: [#&#8203;52683](https://github.com/vercel/next.js/issues/52683) - Fix tracking of ContextModule: [#&#8203;52795](https://github.com/vercel/next.js/issues/52795) - Set process.title for router and render workers: [#&#8203;52779](https://github.com/vercel/next.js/issues/52779) - fix Remove unnecessary await: [#&#8203;52800](https://github.com/vercel/next.js/issues/52800) - Revert "perf: improve URL validation performance": [#&#8203;52818](https://github.com/vercel/next.js/issues/52818) - Refactor the client entry plugin: [#&#8203;52798](https://github.com/vercel/next.js/issues/52798) - Turbopack: Add manifest generation to pages: [#&#8203;52793](https://github.com/vercel/next.js/issues/52793) - Turbopack: move references() to specific traits: [#&#8203;52822](https://github.com/vercel/next.js/issues/52822) - Update default `moduleResolution` in `tsconfig.json` from `node` to `bundler`: [#&#8203;51957](https://github.com/vercel/next.js/issues/51957) - Turbopack: Next.rs API improvements: [#&#8203;52856](https://github.com/vercel/next.js/issues/52856) - update turbopack: [#&#8203;52899](https://github.com/vercel/next.js/issues/52899) - Update vendor [@&#8203;vercel/og](https://github.com/vercel/og): [#&#8203;52897](https://github.com/vercel/next.js/issues/52897) - Fixed:[#&#8203;52853](https://github.com/vercel/next.js/issues/52853) Lacking 'color' attribute in IconDescriptor Metadata: [#&#8203;52902](https://github.com/vercel/next.js/issues/52902) - Support basePath with edge runtime for Custom App Routes: [#&#8203;52910](https://github.com/vercel/next.js/issues/52910) - improve error DX on pages with RSC build errors: [#&#8203;52843](https://github.com/vercel/next.js/issues/52843) - fix: allow smooth scrolling if only hash changes (pages & app): [#&#8203;52915](https://github.com/vercel/next.js/issues/52915) - add edge support for next.rs API: [#&#8203;52885](https://github.com/vercel/next.js/issues/52885) - Allow general language codes in the Metadata API: [#&#8203;52920](https://github.com/vercel/next.js/issues/52920) - Fix client reference manifest for interception routes: [#&#8203;52961](https://github.com/vercel/next.js/issues/52961) - Refine the not-found rendering process for app router: [#&#8203;52790](https://github.com/vercel/next.js/issues/52790) - app-router: prefetching tweaks: [#&#8203;52949](https://github.com/vercel/next.js/issues/52949) - Revert "Refine the not-found rendering process for app router": [#&#8203;52977](https://github.com/vercel/next.js/issues/52977) ##### Documentation Changes - Update mention of route handlers for forms: [#&#8203;52781](https://github.com/vercel/next.js/issues/52781) - (Docs) add missing `js` version for `generateMetadata`.: [#&#8203;52763](https://github.com/vercel/next.js/issues/52763) - docs : fix typo in React cache example: [#&#8203;52787](https://github.com/vercel/next.js/issues/52787) - chore(docs): Add mentioning of HOSTNAME env variable for standalone output: [#&#8203;52804](https://github.com/vercel/next.js/issues/52804) - Fix typo in docs: [#&#8203;52815](https://github.com/vercel/next.js/issues/52815) - Update 02-edge-and-nodejs-runtimes.mdx: [#&#8203;52888](https://github.com/vercel/next.js/issues/52888) - chore(docs): add Typescript statically typed links mention in link doc: [#&#8203;52847](https://github.com/vercel/next.js/issues/52847) - chore(docs): fix typo in generate metadata docs: [#&#8203;52904](https://github.com/vercel/next.js/issues/52904) - fix example component in MDX documentation: [#&#8203;52753](https://github.com/vercel/next.js/issues/52753) - wrong content for next.config.mjs for MDX Plugins: [#&#8203;52738](https://github.com/vercel/next.js/issues/52738) - Update 06-lazy-loading.mdx: Incorrect filename in Example on "Importing Named Imports": [#&#8203;52932](https://github.com/vercel/next.js/issues/52932) - Change "publically" to "publicly" in the routing docs: [#&#8203;52966](https://github.com/vercel/next.js/issues/52966) ##### Example Changes - examples: export `force-dynamic` from all dynamic routes: [#&#8203;52916](https://github.com/vercel/next.js/issues/52916) ##### Misc Changes - chore: add "please simplify reproduction" comment: [#&#8203;52631](https://github.com/vercel/next.js/issues/52631) - update job concurrency: [#&#8203;52788](https://github.com/vercel/next.js/issues/52788) - Lock node version to 18.16: [#&#8203;52894](https://github.com/vercel/next.js/issues/52894) - Update runs-on tags - chore: add GitHub Action to manage "+1" comments: [#&#8203;52866](https://github.com/vercel/next.js/issues/52866) ##### Credits Huge thanks to [@&#8203;styfle](https://github.com/styfle), [@&#8203;huozhi](https://github.com/huozhi), [@&#8203;balazsorban44](https://github.com/balazsorban44), [@&#8203;kwonoj](https://github.com/kwonoj), [@&#8203;alexkirsz](https://github.com/alexkirsz), [@&#8203;ijjk](https://github.com/ijjk), [@&#8203;Jeffrey-Zutt](https://github.com/Jeffrey-Zutt), [@&#8203;timneutkens](https://github.com/timneutkens), [@&#8203;vinaykulk621](https://github.com/vinaykulk621), [@&#8203;Ryan-Dia](https://github.com/Ryan-Dia), [@&#8203;sokra](https://github.com/sokra), [@&#8203;shuding](https://github.com/shuding), [@&#8203;steppefox](https://github.com/steppefox), [@&#8203;hiro0218](https://github.com/hiro0218), [@&#8203;rjsdnql123](https://github.com/rjsdnql123), [@&#8203;feedthejim](https://github.com/feedthejim), [@&#8203;fgiuliani](https://github.com/fgiuliani), [@&#8203;steven-tey](https://github.com/steven-tey), [@&#8203;AntoineBourin](https://github.com/AntoineBourin), [@&#8203;adamrhunter](https://github.com/adamrhunter), [@&#8203;darshanjain-entrepreneur](https://github.com/darshanjain-entrepreneur), [@&#8203;s0h311](https://github.com/s0h311), [@&#8203;wyattjoh](https://github.com/wyattjoh), [@&#8203;ztanner](https://github.com/ztanner), [@&#8203;djreillo](https://github.com/djreillo), [@&#8203;dijonmusters](https://github.com/dijonmusters), and [@&#8203;cassidoo](https://github.com/cassidoo) for helping! ### [`v13.4.10`](https://github.com/vercel/next.js/releases/tag/v13.4.10) [Compare Source](https://github.com/vercel/next.js/compare/v13.4.9...v13.4.10) ##### Core Changes - Fix trailing slash with locale domain: [#&#8203;52343](https://github.com/vercel/next.js/issues/52343) - perf: use fs.readdirSync with withFileTypes: [#&#8203;52340](https://github.com/vercel/next.js/issues/52340) - Make `get_client_chunking_context` independent of context: [#&#8203;51928](https://github.com/vercel/next.js/issues/51928) - perf: use fs.opendir for better resource usage: [#&#8203;52341](https://github.com/vercel/next.js/issues/52341) - fix: metadatabase warning message: [#&#8203;52363](https://github.com/vercel/next.js/issues/52363) - perf: simplify getShortDynamicParamType on app-render: [#&#8203;52355](https://github.com/vercel/next.js/issues/52355) - fix: prevent infinite dev refresh on nested parallel routes: [#&#8203;52362](https://github.com/vercel/next.js/issues/52362) - turbopack: add incremental cache for node.js app rendering: [#&#8203;52172](https://github.com/vercel/next.js/issues/52172) - Refactor metadata og and twitter title to be always presented: [#&#8203;52320](https://github.com/vercel/next.js/issues/52320) - perf: reduce system calls on eslint plugin: [#&#8203;52359](https://github.com/vercel/next.js/issues/52359) - Turbopack: Use a different chunking context for web entry: [#&#8203;52404](https://github.com/vercel/next.js/issues/52404) - Temporarily revert change to pages render: [#&#8203;52407](https://github.com/vercel/next.js/issues/52407) - Remove integration tests now in vercel/turbo: [#&#8203;52413](https://github.com/vercel/next.js/issues/52413) - Update Rust nightly toolchain: [#&#8203;51757](https://github.com/vercel/next.js/issues/51757) - Cache concurrent `ensurePage` requests for the same page: [#&#8203;52360](https://github.com/vercel/next.js/issues/52360) - \[turbopack]: Remove skipped integration tests: [#&#8203;52421](https://github.com/vercel/next.js/issues/52421) - Fix metadata layer webpack rule for server-only: [#&#8203;52403](https://github.com/vercel/next.js/issues/52403) - Override file based images with social images property: [#&#8203;52416](https://github.com/vercel/next.js/issues/52416) - Split the client reference manifest file to be generated per-entry: [#&#8203;52450](https://github.com/vercel/next.js/issues/52450) - fix(standalone): fixed `output: "standalone"` crashing build when there is no `app/` page: [#&#8203;51993](https://github.com/vercel/next.js/issues/51993) - fix: add aws packages to default `serverComponentsExternalPackages`: [#&#8203;52388](https://github.com/vercel/next.js/issues/52388) - refactor: avoid unnecessary async scopes in eslint: [#&#8203;52418](https://github.com/vercel/next.js/issues/52418) - Ensure useParams return array for catch-all routes: [#&#8203;52494](https://github.com/vercel/next.js/issues/52494) - turbopack: Module Trait: [#&#8203;52401](https://github.com/vercel/next.js/issues/52401) - Fix tracking of client reference manifest: [#&#8203;52505](https://github.com/vercel/next.js/issues/52505) - perf: create an experimental bundled version of the next server: [#&#8203;52206](https://github.com/vercel/next.js/issues/52206) - Chore: Remove redundant intersection type: [#&#8203;52453](https://github.com/vercel/next.js/issues/52453) - perf: Refactor recursiveReadDirSync: [#&#8203;52517](https://github.com/vercel/next.js/issues/52517) - add version to function config manifest: [#&#8203;52507](https://github.com/vercel/next.js/issues/52507) - Turbopack: Source trait: [#&#8203;52511](https://github.com/vercel/next.js/issues/52511) - Update id handling for fonts: [#&#8203;52559](https://github.com/vercel/next.js/issues/52559) - feat(turbopack): support swc transform plugins : [#&#8203;50401](https://github.com/vercel/next.js/issues/50401) - feat(babel-loader): provide migration help message for babel config: [#&#8203;52565](https://github.com/vercel/next.js/issues/52565) - Support global-error for ssr fallback: [#&#8203;52573](https://github.com/vercel/next.js/issues/52573) - Fix ISR case with bot requests: [#&#8203;52581](https://github.com/vercel/next.js/issues/52581) - fix(next/jest): jest can not load server-only code: [#&#8203;52393](https://github.com/vercel/next.js/issues/52393) - Turbopack: App Router build POC: [#&#8203;52036](https://github.com/vercel/next.js/issues/52036) - Avoid loading Next.js config again in render workers: [#&#8203;52587](https://github.com/vercel/next.js/issues/52587) - Add more extensions to `next-types-plugin` for `Node16`/`NodeNext`: [#&#8203;52562](https://github.com/vercel/next.js/issues/52562) - feat(next-swc): report native bindings load err code: [#&#8203;52570](https://github.com/vercel/next.js/issues/52570) - Move App Pages rendering into bundle: [#&#8203;52290](https://github.com/vercel/next.js/issues/52290) - feat(turbopack): support native webp: [#&#8203;52285](https://github.com/vercel/next.js/issues/52285) - Set sizes prop to any for svg icons: [#&#8203;52609](https://github.com/vercel/next.js/issues/52609) - Turbopack: OutputAsset trait: [#&#8203;52606](https://github.com/vercel/next.js/issues/52606) - chore(deps): bump `react@18.3.0-canary-9377e1010-20230712`: [#&#8203;52649](https://github.com/vercel/next.js/issues/52649) - Ensure root layout only render once per request: [#&#8203;52589](https://github.com/vercel/next.js/issues/52589) - Fix bundle path normalization for /index routes: [#&#8203;52650](https://github.com/vercel/next.js/issues/52650) - Turobpack: Next.rs API (part 1): [#&#8203;52259](https://github.com/vercel/next.js/issues/52259) - Clean up promises after resolving: [#&#8203;52656](https://github.com/vercel/next.js/issues/52656) - Catch layout error in global-error: [#&#8203;52654](https://github.com/vercel/next.js/issues/52654) - Fix per-entry client reference manifest for grouped and named segments: [#&#8203;52664](https://github.com/vercel/next.js/issues/52664) ##### Documentation Changes - chore(docs): fix link to `useSearchParams`: [#&#8203;52348](https://github.com/vercel/next.js/issues/52348) - docs: Clarify `create-next-app` requires public GitHub URLs.: [#&#8203;52367](https://github.com/vercel/next.js/issues/52367) - remove unnecessary dot.: [#&#8203;52387](https://github.com/vercel/next.js/issues/52387) - fix metadata-related typo in MDX documentation: [#&#8203;52446](https://github.com/vercel/next.js/issues/52446) - docs: Simplify message in React essentials section.: [#&#8203;52469](https://github.com/vercel/next.js/issues/52469) - docs: Improve error handling docs for server-side errors.: [#&#8203;52302](https://github.com/vercel/next.js/issues/52302) - docs: Add Playwright/Cypress Discord links: [#&#8203;52084](https://github.com/vercel/next.js/issues/52084) - docs: Add Kuma to CSS-in-JS supported list.: [#&#8203;52438](https://github.com/vercel/next.js/issues/52438) - docs: clarify `fetch` request de-duplication: [#&#8203;52100](https://github.com/vercel/next.js/issues/52100) - docs: Update TypeScript plugin section for VS Code prompt: [#&#8203;52111](https://github.com/vercel/next.js/issues/52111) - docs: Improve hydration mismatch error guide.: [#&#8203;52481](https://github.com/vercel/next.js/issues/52481) - docs: add Supabase loader for `next/image`: [#&#8203;52480](https://github.com/vercel/next.js/issues/52480) - docs: fix the incrementalCacheHandlerPath: [#&#8203;52124](https://github.com/vercel/next.js/issues/52124) - fixed error [#&#8203;52486](https://github.com/vercel/next.js/issues/52486) fetchUsers to fetchUser: [#&#8203;52487](https://github.com/vercel/next.js/issues/52487) - Update 08-parallel-routes.mdx: [#&#8203;52419](https://github.com/vercel/next.js/issues/52419) - docs: Add `formData` example for Route Handlers: [#&#8203;52358](https://github.com/vercel/next.js/issues/52358) - chore(docs): Typesafe `metadata` object: [#&#8203;52252](https://github.com/vercel/next.js/issues/52252) - docs: Update `_app` and `_document`: [#&#8203;52479](https://github.com/vercel/next.js/issues/52479) - docs: add CDN optimization as possible hydration error cause: [#&#8203;52489](https://github.com/vercel/next.js/issues/52489) - docs: correct TypeScript spelling on the home page: [#&#8203;52500](https://github.com/vercel/next.js/issues/52500) - chore(docs): fix a few typos in image loader docs: [#&#8203;52508](https://github.com/vercel/next.js/issues/52508) - docs: fix grammar on Server Actions: [#&#8203;52556](https://github.com/vercel/next.js/issues/52556) - Fixed grammar in 03-react-essentials.mdx: [#&#8203;52597](https://github.com/vercel/next.js/issues/52597) - docs: fix typo in CSS Modules Description: [#&#8203;52599](https://github.com/vercel/next.js/issues/52599) - docs: Fix typo in generate-static-params.mdx: [#&#8203;52595](https://github.com/vercel/next.js/issues/52595) - docs: move MUI to supported list: [#&#8203;52584](https://github.com/vercel/next.js/issues/52584) - docs: Add missing closing tag for react hydration error message.: [#&#8203;52607](https://github.com/vercel/next.js/issues/52607) ##### Example Changes - examples: Update Convex to latest version (`0.19`): [#&#8203;52473](https://github.com/vercel/next.js/issues/52473) - Update examples: counter.tsx - Don't need empty space: [#&#8203;52576](https://github.com/vercel/next.js/issues/52576) ##### Misc Changes - Update swc_core to `v0.79.13`: [#&#8203;52371](https://github.com/vercel/next.js/issues/52371) - chore(ci): fix turbo input path globs: [#&#8203;52414](https://github.com/vercel/next.js/issues/52414) - fix(create-next-app): click event blockage under 1024px by adjusting z-index: [#&#8203;52074](https://github.com/vercel/next.js/issues/52074) - chore: add label to locked threads: [#&#8203;52497](https://github.com/vercel/next.js/issues/52497) - fix: `not-found.tsx` with `output: export`: [#&#8203;52526](https://github.com/vercel/next.js/issues/52526) - use `npm pack` instead of `yarn pack`: [#&#8203;52563](https://github.com/vercel/next.js/issues/52563) - ci: skip build-native for docs only change: [#&#8203;52571](https://github.com/vercel/next.js/issues/52571) - Remove unnecessary `body-parser`: [#&#8203;52580](https://github.com/vercel/next.js/issues/52580) ##### Credits Huge thanks to [@&#8203;ijjk](https://github.com/ijjk), [@&#8203;anonrig](https://github.com/anonrig), [@&#8203;alexkirsz](https://github.com/alexkirsz), [@&#8203;gfgabrielfranca](https://github.com/gfgabrielfranca), [@&#8203;styfle](https://github.com/styfle), [@&#8203;ztanner](https://github.com/ztanner), [@&#8203;leerob](https://github.com/leerob), [@&#8203;sokra](https://github.com/sokra), [@&#8203;huozhi](https://github.com/huozhi), [@&#8203;Bitbbot](https://github.com/Bitbbot), [@&#8203;wyattjoh](https://github.com/wyattjoh), [@&#8203;kdy1](https://github.com/kdy1), [@&#8203;wbinnssmith](https://github.com/wbinnssmith), [@&#8203;shuding](https://github.com/shuding), [@&#8203;jridgewell](https://github.com/jridgewell), [@&#8203;BrennanColberg](https://github.com/BrennanColberg), [@&#8203;Nick-Mazuk](https://github.com/Nick-Mazuk), [@&#8203;delbaoliveira](https://github.com/delbaoliveira), [@&#8203;thomasballinger](https://github.com/thomasballinger), [@&#8203;lucgagan](https://github.com/lucgagan), [@&#8203;nroland013](https://github.com/nroland013), [@&#8203;SonMooSans](https://github.com/SonMooSans), [@&#8203;jenewland1999](https://github.com/jenewland1999), [@&#8203;thorwebdev](https://github.com/thorwebdev), [@&#8203;jyunhanlin](https://github.com/jyunhanlin), [@&#8203;darshanjain-entrepreneur](https://github.com/darshanjain-entrepreneur), [@&#8203;DuCanhGH](https://github.com/DuCanhGH), [@&#8203;Gnadhi](https://github.com/Gnadhi), [@&#8203;yagogmaisp](https://github.com/yagogmaisp), [@&#8203;carlos-menezes](https://github.com/carlos-menezes), [@&#8203;balazsorban44](https://github.com/balazsorban44), [@&#8203;ryo-manba](https://github.com/ryo-manba), [@&#8203;timneutkens](https://github.com/timneutkens), [@&#8203;feedthejim](https://github.com/feedthejim), [@&#8203;vamcs](https://github.com/vamcs), [@&#8203;matepapp](https://github.com/matepapp), [@&#8203;SleeplessOne1917](https://github.com/SleeplessOne1917), [@&#8203;ecklf](https://github.com/ecklf), [@&#8203;djreillo](https://github.com/djreillo), [@&#8203;kwonoj](https://github.com/kwonoj), [@&#8203;gnoff](https://github.com/gnoff), [@&#8203;feugy](https://github.com/feugy), [@&#8203;karlhorky](https://github.com/karlhorky), [@&#8203;starunaway](https://github.com/starunaway), [@&#8203;FernandVEYRIER](https://github.com/FernandVEYRIER), [@&#8203;Ryan-Dia](https://github.com/Ryan-Dia), [@&#8203;Terro216](https://github.com/Terro216), [@&#8203;anthonyshew](https://github.com/anthonyshew), and [@&#8203;suhaotian](https://github.com/suhaotian) for helping! ### [`v13.4.9`](https://github.com/vercel/next.js/releases/tag/v13.4.9) [Compare Source](https://github.com/vercel/next.js/compare/v13.4.8...v13.4.9) ##### Core Changes - Reland "ReverseTopological -> AdjacencyMap"": [#&#8203;52142](https://github.com/vercel/next.js/issues/52142) - Change the Server Actions feature flag to be validated at compile time: [#&#8203;52147](https://github.com/vercel/next.js/issues/52147) - Fix `modularizeImports` transform of `antd`: [#&#8203;52148](https://github.com/vercel/next.js/issues/52148) - fix: next.config.js with `unstable_getImgProps()`: [#&#8203;52153](https://github.com/vercel/next.js/issues/52153) - update tests list to include all passing tests: [#&#8203;52026](https://github.com/vercel/next.js/issues/52026) - Support scroll: false for Link component for app router: [#&#8203;51869](https://github.com/vercel/next.js/issues/51869) - Memoize useRouter from next/navigation when used in Pages Router: [#&#8203;52177](https://github.com/vercel/next.js/issues/52177) - chore(deps): bump react `18.3.0-canary-1fdacbefd-20230630`: [#&#8203;52005](https://github.com/vercel/next.js/issues/52005) - fix: infinite dev reloads when parallel route is treated a page entry: [#&#8203;52061](https://github.com/vercel/next.js/issues/52061) - disable flaky test cases: [#&#8203;52184](https://github.com/vercel/next.js/issues/52184) - Revert "chore(deps): bump react `18.3.0-canary-1fdacbefd-20230630`": [#&#8203;52192](https://github.com/vercel/next.js/issues/52192) - update turbopack: [#&#8203;52186](https://github.com/vercel/next.js/issues/52186) - Update CustomModuleType import: [#&#8203;52133](https://github.com/vercel/next.js/issues/52133) - Skip build-time dynamic code checks for specific polyfills in the Edge runtime: [#&#8203;52009](https://github.com/vercel/next.js/issues/52009) - Update Turbopack: [#&#8203;52198](https://github.com/vercel/next.js/issues/52198) - Use base36 for the RSC query: [#&#8203;52204](https://github.com/vercel/next.js/issues/52204) - Fix `dynamicParams` check in TS plugin: [#&#8203;52211](https://github.com/vercel/next.js/issues/52211) - Fix tree shaking for image generation module: [#&#8203;51950](https://github.com/vercel/next.js/issues/51950) - fix env reloading for turbopack: [#&#8203;52194](https://github.com/vercel/next.js/issues/52194) - Remove zod from require-hook: [#&#8203;52197](https://github.com/vercel/next.js/issues/52197) - Optimize watch ignore: [#&#8203;52238](https://github.com/vercel/next.js/issues/52238) - Remove the outdated error for find page dir: [#&#8203;52274](https://github.com/vercel/next.js/issues/52274) - Disable flakey turbopack env test: [#&#8203;52295](https://github.com/vercel/next.js/issues/52295) - skip hot reload sync event for applying hmr updates: [#&#8203;52270](https://github.com/vercel/next.js/issues/52270) - Handle 409s in fetch cache: [#&#8203;51652](https://github.com/vercel/next.js/issues/51652) - chore: remove experimental `appDir: true` from tests: [#&#8203;52291](https://github.com/vercel/next.js/issues/52291) - fix: correct `modularizeImports` for antd & ant-design/icons: [#&#8203;52169](https://github.com/vercel/next.js/issues/52169) - Update checksum algorithm to SHA1: [#&#8203;52102](https://github.com/vercel/next.js/issues/52102) - chore(deps): bump react to [`7118f5d`](https://github.com/vercel/next.js/commit/7118f5dd7): [#&#8203;52282](https://github.com/vercel/next.js/issues/52282) - Update eslint-plugin-react-hooks to 5.0.0-canary-7118f5dd7-20230705: [#&#8203;52275](https://github.com/vercel/next.js/issues/52275) - Named page chunks: [#&#8203;51921](https://github.com/vercel/next.js/issues/51921) - chore: fix next dev turbopack benchmark: [#&#8203;52328](https://github.com/vercel/next.js/issues/52328) - Fix to use keep-alive in standalone mode: [#&#8203;50221](https://github.com/vercel/next.js/issues/50221) - Use 127.0.0.1 as the default host for the standalone server [#&#8203;52283](https://github.com/vercel/next.js/issues/52283) ##### Documentation Changes - Update generate-image-metadata.mdx: [#&#8203;52230](https://github.com/vercel/next.js/issues/52230) - docs(mdx): Add clearer instructions on the storage location of mdx-components files.: [#&#8203;52187](https://github.com/vercel/next.js/issues/52187) - docs: Improve some of the error messages pages.: [#&#8203;52271](https://github.com/vercel/next.js/issues/52271) - fix wrong Link import: [#&#8203;52298](https://github.com/vercel/next.js/issues/52298) - Document redirect parameters: [#&#8203;51987](https://github.com/vercel/next.js/issues/51987) - Add manual installation instructions for pages: [#&#8203;51995](https://github.com/vercel/next.js/issues/51995) - Update 10-router-handlers.mdx: [#&#8203;52098](https://github.com/vercel/next.js/issues/52098) - Add app router example: [#&#8203;52066](https://github.com/vercel/next.js/issues/52066) - doc: update typo in instrumentation page: [#&#8203;52311](https://github.com/vercel/next.js/issues/52311) ##### Example Changes - Remove legacy head.js in examples: [#&#8203;52292](https://github.com/vercel/next.js/issues/52292) ##### Misc Changes - Update test result step: [#&#8203;52154](https://github.com/vercel/next.js/issues/52154) - Update result job condition: [#&#8203;52155](https://github.com/vercel/next.js/issues/52155) - fix workflow needs: [#&#8203;52180](https://github.com/vercel/next.js/issues/52180) - chore: update issue template option to "App Router": [#&#8203;52287](https://github.com/vercel/next.js/issues/52287) - msic: disable otel esm test: [#&#8203;52325](https://github.com/vercel/next.js/issues/52325) - Test Progressive Enhancement of Server Actions: [#&#8203;52062](https://github.com/vercel/next.js/issues/52062) - fix(create-next-app): add missing metadata type: [#&#8203;52299](https://github.com/vercel/next.js/issues/52299) ##### Credits Huge thanks to [@&#8203;huozhi](https://github.com/huozhi), [@&#8203;shuding](https://github.com/shuding), [@&#8203;ijjk](https://github.com/ijjk), [@&#8203;styfle](https://github.com/styfle), [@&#8203;sokra](https://github.com/sokra), [@&#8203;timneutkens](https://github.com/timneutkens), [@&#8203;ztanner](https://github.com/ztanner), [@&#8203;alexkirsz](https://github.com/alexkirsz), [@&#8203;simonswiss](https://github.com/simonswiss), [@&#8203;feikerwu](https://github.com/feikerwu), [@&#8203;lubakravche](https://github.com/lubakravche), [@&#8203;leerob](https://github.com/leerob), [@&#8203;masnormen](https://github.com/masnormen), [@&#8203;bottxiang](https://github.com/bottxiang), [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;delbaoliveira](https://github.com/delbaoliveira), [@&#8203;feedthejim](https://github.com/feedthejim), [@&#8203;mhmdrioaf](https://github.com/mhmdrioaf), [@&#8203;tyler-lutz](https://github.com/tyler-lutz), [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;vincenthongzy](https://github.com/vincenthongzy), [@&#8203;yigithanyucedag](https://github.com/yigithanyucedag), and [@&#8203;doinki](https://github.com/doinki) for helping! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
kjuulh force-pushed renovate/nextjs-monorepo from ae73880bdd to 2f922e270c 2023-07-25 00:33:15 +02:00 Compare
kjuulh merged commit 2f922e270c into main 2023-07-25 00:55:57 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kjuulh/todo#136
No description provided.
Delete Branch "renovate/nextjs-monorepo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?