Commit Graph

2061 Commits

Author SHA1 Message Date
Nathan Kent
86d86a85e4 Remove unsound casting functions
The casting functions in `unsafe.rs` were unsound (i.e., they allowed
safe code to cause undefined behavior). While they did appear to be used
in a way that wouldn't cause UB the fact that there exists unsound
functions is unsettling.

This commit removes those functions and replaces it with a macro that
performs the same reification - the difference is that the macro call
will also include the checks which are required to prevent UB. A macro
was chosen instead of a function for two reasons:

1. A macro can keep the same code generation whereas a function would
   require going through an `Option` which has negative impacts on code
   generation (niche values cause poor DCE).
2. There exist other `unsafe` code blocks in the crate and an attempt to
   make Rhai 100% safe is completely out-of-scope for this merge
   request, so we may as well use `unsafe` in the macro.

Regarding (2) above, I may come back at a later date with a 100% safe
`reify` function but only once the other `unsafe` blocks are removed.
For posterity, said function would look something like:

```rust
fn reify<A: Any, C>(value: A) -> Option<C> {
    let mut v = Some(value);
    let v: &mut dyn Any = &mut v;
    v.downcast_mut::<Option<C>>().map(Option::take)
}
```
2022-02-05 16:29:05 -08:00
Stephen Chung
6a740a9fa1 Fix no_module build. 2022-02-04 23:08:09 +08:00
Stephen Chung
be9356727f Add variable definition filter. 2022-02-04 22:59:41 +08:00
Stephen Chung
936dc01e39 Pass level to var resolver. 2022-02-04 22:16:12 +08:00
Stephen Chung
5aee06674f Fix no-std build. 2022-02-04 16:38:01 +08:00
Stephen Chung
f09abd7ab3 Fix builds. 2022-02-04 13:31:33 +08:00
Stephen Chung
3be27746e0 Add allow_shadowing. 2022-02-04 13:20:47 +08:00
Stephen Chung
6c1c8bc538 Improve position display. 2022-02-04 12:04:33 +08:00
Stephen Chung
345a060672 Fix type name display. 2022-02-03 23:54:53 +08:00
Stephen Chung
419ee45043 Add bin-features to pull in all features for bin tools. 2022-02-03 21:17:47 +08:00
Stephen Chung
9fa6839380 Simplify debugger calls. 2022-02-03 11:56:08 +08:00
Stephen Chung
8322e62c18 Fix function exit trigger and add function enter trigger. 2022-02-02 22:42:33 +08:00
Stephen Chung
db2f1a601c Make call stack available also under no_function. 2022-02-02 15:07:22 +08:00
Stephen Chung
e0ed713bb6 Fix builds. 2022-02-02 14:57:30 +08:00
Stephen Chung
4a80483749 Support call stack and FunctionExit for native functions. 2022-02-02 14:47:35 +08:00
Stephen Chung
7163a7331a Add commands and status to debugging interface. 2022-02-01 22:30:05 +08:00
Stephen Chung
dca0185323 Change on_debugger to register_debugger. 2022-02-01 14:07:06 +08:00
Stephen Chung
389bb9bf66 Add history recall to repl. 2022-01-31 21:02:36 +08:00
Stephen Chung
f1458e79e0 Improve AST debug display. 2022-01-31 13:38:27 +08:00
Stephen Chung
ff06bb98a1 Fix no_module build. 2022-01-30 23:28:02 +08:00
Stephen Chung
7b92a80c32 Fix encapsulated environment in module functions. 2022-01-30 17:27:13 +08:00
Stephen Chung
8fc80ecd10 Fix formatting. 2022-01-30 11:21:45 +08:00
Stephen Chung
06214cf499 Add key bindings to repl. 2022-01-30 09:42:04 +08:00
Stephen Chung
0378c822e1 Use required-features for bin tools. 2022-01-30 09:41:51 +08:00
Stephen Chung
2cfd426aaf Merge branch 'rustyline' of https://github.com/rhaiscript/rhai 2022-01-29 15:59:24 +08:00
Stephen Chung
19ef92a3f3 Fix builds. 2022-01-29 13:37:58 +08:00
Stephen Chung
6b02dde848 Gate dead code for no_module. 2022-01-29 11:09:43 +08:00
Jonathan Strong
16f13960f4 poc: adds rustyline to rhai-repl 2022-01-28 20:29:25 -05:00
Stephen Chung
4ee6657b9d Fix no_function build. 2022-01-28 22:37:59 +08:00
Stephen Chung
cd4335a16f Fix builds. 2022-01-28 22:11:22 +08:00
Stephen Chung
c397a6dcb5 Fix sync build. 2022-01-28 22:07:49 +08:00
Stephen Chung
c93e94c7cd Fix builds. 2022-01-28 21:35:16 +08:00
Stephen Chung
66af69aaff Refactor and add state to debugger. 2022-01-28 18:59:18 +08:00
Stephen Chung
20baae71d4 Factor tuples into structs to aid in understanding. 2022-01-28 10:11:40 +08:00
Stephen Chung
b86dd3f586 Add missing data size check. 2022-01-28 08:28:31 +08:00
Stephen Chung
b9f2fdb635 Rename AST option flags. 2022-01-28 08:28:17 +08:00
Stephen Chung
09d03d07ed Fix sync build. 2022-01-28 08:00:46 +08:00
Stephen Chung
e476929597 Remove Box on callback traits. 2022-01-27 23:55:32 +08:00
Stephen Chung
64de20bcd3 Remove warnings. 2022-01-27 16:58:11 +08:00
Stephen Chung
dd937e657d Fix builds. 2022-01-27 16:58:11 +08:00
Stephen Chung
197cdedaf4 Add commands to rhai-dbg. 2022-01-27 16:58:11 +08:00
Stephen Chung
d75c3e1592 Change stack trace object property name. 2022-01-27 16:58:11 +08:00
Stephen Chung
edcc95e205 Skip transitive nodes for debugger. 2022-01-27 16:58:11 +08:00
Stephen Chung
538af8caee Scope::clone_visible clones value access mode also. 2022-01-27 16:58:11 +08:00
Stephen Chung
14e42f436f Make scan_imports_raw public. 2022-01-27 16:58:11 +08:00
Stephen Chung
c8357de1c8 Fix feature builds. 2022-01-27 16:58:11 +08:00
Stephen Chung
3c2ac7f0c5 Add ability for debugger to throw errors. 2022-01-27 16:58:11 +08:00
Stephen Chung
b4f679d35f Add property breakpoints. 2022-01-27 16:58:11 +08:00
Stephen Chung
cc64ae3939 Fix no-std build. 2022-01-27 16:58:11 +08:00
Stephen Chung
efddc7e91d Add breaking at line. 2022-01-27 16:58:11 +08:00
Stephen Chung
2dc1fea40a Remove non_snake_case warnings. 2022-01-27 16:58:11 +08:00
Stephen Chung
aee35e5f20 Add DebuggingPackage. 2022-01-27 16:58:11 +08:00
Stephen Chung
0e5f62574d Fix warnings. 2022-01-27 16:58:11 +08:00
Stephen Chung
3cec9751bf Remove call stack under no_function. 2022-01-27 16:58:11 +08:00
Stephen Chung
40aaab60c3 Refine debugger. 2022-01-27 16:58:11 +08:00
Stephen Chung
fc87dec128 Add debugging interface. 2022-01-27 16:58:11 +08:00
Stephen Chung
69dab31617 Remove need for default features in dependencies. 2022-01-27 08:22:20 +08:00
Stephen Chung
c79f1e44e4 Refine position display of indexing. 2022-01-25 10:56:22 +08:00
Stephen Chung
d8a6b93f43 Fix off-by-one position error after comment line. 2022-01-24 16:06:41 +08:00
Stephen Chung
2b2685e387 Add optimize command to REPL. 2022-01-24 15:50:25 +08:00
Stephen Chung
8d34ffb9f5 Fix bug in try block. 2022-01-24 08:34:21 +08:00
Stephen Chung
97be256a1a Fix bug with optimizing op-assignment operators. 2022-01-23 21:09:37 +08:00
Stephen Chung
fb0b071fe0 Add lifetimes to GlobalRuntimeState and EvalState for future needs. 2022-01-22 17:48:07 +08:00
Stephen Chung
c32ace40a4 Fix builds. 2022-01-22 17:27:18 +08:00
Stephen Chung
f92894e337 Rename GlobalRuntimeStatemodules -> imports. 2022-01-20 08:17:34 +08:00
Stephen Chung
3d4abeed0e New metadata functions. 2022-01-20 08:16:38 +08:00
Stephen Chung
0b3250a262 Add strict command to rhai-repl. 2022-01-19 14:02:55 +08:00
Stephen Chung
f0781c9736 Properly handle \r\n pairs in doc-comments. 2022-01-17 23:15:51 +08:00
Stephen Chung
d58df1fb34 Engine::gen_fn_signatures enumerates non-standard external packages. 2022-01-17 23:15:22 +08:00
Stephen Chung
86fc2f7bf1 Refine types display. 2022-01-17 21:51:04 +08:00
Stephen Chung
58e1094b79 Register test functions in repl. 2022-01-17 21:50:36 +08:00
Stephen Chung
16c03cc864 Add comments to standard library functions. 2022-01-17 21:49:06 +08:00
Stephen Chung
5232bbbff8 Add get/set methods to arrays, blobs, maps and strings. 2022-01-17 10:21:03 +08:00
Stephen Chung
573bfe46dd Fix formatting. 2022-01-17 07:50:29 +08:00
Stephen Chung
57cfd6a354 Fix builds. 2022-01-16 23:15:37 +08:00
Stephen Chung
24b68971a8 Fix offset calc. 2022-01-16 22:54:28 +08:00
Stephen Chung
5935a88958 Revert "Refine examples."
This reverts commit 146129279c.
2022-01-16 22:50:39 +08:00
Stephen Chung
146129279c Refine examples. 2022-01-16 22:45:49 +08:00
Stephen Chung
3667761340 Fix bugs and add comments to standard library. 2022-01-15 23:34:38 +08:00
Stephen Chung
e24848668a Fix build. 2022-01-15 11:35:44 +08:00
Stephen Chung
00b189d0c6 Replace Cow<str> in Scope with SmartString. 2022-01-15 11:26:43 +08:00
Stephen Chung
2a8a8c00f5 Refine calc_index API. 2022-01-15 10:24:08 +08:00
Stephen Chung
a8ec984b0f Fix unsafe violation in for loop. 2022-01-15 10:18:16 +08:00
Stephen Chung
ae77582028 Minor refactor. 2022-01-14 21:49:38 +08:00
Stephen Chung
e2e0b8d083 Fix Array::chop. 2022-01-14 10:04:24 +08:00
Stephen Chung
96764c0d2d Fix UINT -> UNSIGNED_INT. 2022-01-13 22:51:56 +08:00
Stephen Chung
25f54c0ea5 Pretty-display return types. 2022-01-13 22:51:10 +08:00
Stephen Chung
5ab7c59ba0 Fix Array::pad infinite loop. 2022-01-13 22:05:07 +08:00
Stephen Chung
5e32af0ceb Fix unchecked build. 2022-01-13 21:08:36 +08:00
Stephen Chung
510c201d2f Fix build. 2022-01-13 21:01:56 +08:00
Stephen Chung
09aa9fc3db Extract metadata into separate type. 2022-01-13 19:07:56 +08:00
Stephen Chung
a3a527923a Fix metadata param name in JSON. 2022-01-13 18:13:38 +08:00
Stephen Chung
0f4e8848f9 Extract index calculataion into functions. 2022-01-13 18:13:27 +08:00
Stephen Chung
4b4a6c944d Fix test. 2022-01-12 11:01:03 +08:00
Stephen Chung
37dbc68bf5 Use target_family for wasm. 2022-01-12 08:12:28 +08:00
Stephen Chung
77eb96bd7e Fix errors. 2022-01-11 11:40:08 +08:00
Stephen Chung
6dedb1ed9f Fix no_std builds. 2022-01-11 11:33:54 +08:00
Stephen Chung
f205091d0a Inline traits impl. 2022-01-10 22:51:24 +08:00
Stephen Chung
56217e386e Fix debug for Engine. 2022-01-10 22:51:04 +08:00
Stephen Chung
5d90b3274c Catch unsupported custom syntax. 2022-01-10 20:08:03 +08:00