2 Commits

Author SHA1 Message Date
113e5282ef fix(crate): initial pr always included the entire changelog
All checks were successful
continuous-integration/drone/pr Build is passing
continuous-integration/drone/push Build is passing
Signed-off-by: kjuulh <contact@kjuulh.io>
2023-08-04 15:01:32 +02:00
fa67dfeee3 fix(crate): always prefix with 'v' when creating prs, or releases (#9)
All checks were successful
continuous-integration/drone/push Build is passing
We don't want rust versions to include the 'v',

however, many languages and tools require it. As such we're choosing when to do it, in this case at the api layer.

Signed-off-by: kjuulh <contact@kjuulh.io>
Reviewed-on: #9
Co-authored-by: kjuulh <contact@kjuulh.io>
Co-committed-by: kjuulh <contact@kjuulh.io>
2023-08-04 12:41:31 +00:00
3 changed files with 11 additions and 6 deletions

View File

@@ -49,9 +49,12 @@ See docs for more information about installation and some such
### 0.3 Milestone
- [ ] Fix: 0.0.0 -> **v**0.0.0
- [ ] Add release strategies
- [ ] Add reporter for PR and Repositories
- [ ] Add inquire for missing values when needed (when not running in ci or have a proper tty)
- [ ] Break down cuddle-please-misc
- [ ] ci(release): Add cuddle-please release artifacts for the different os and so on.
### 0.x Milestone
- [ ] Add github support

View File

@@ -149,7 +149,8 @@ impl ReleaseCommandHandler {
owner,
repository,
&next_version.to_string(),
&changelog_last_changes.unwrap(),
&changelog_last_changes
.ok_or(anyhow::anyhow!("could not get the latest changes"))?,
existing_pr,
)?
} else {
@@ -164,7 +165,8 @@ impl ReleaseCommandHandler {
owner,
repository,
&next_version.to_string(),
&changelog,
&changelog_last_changes
.ok_or(anyhow::anyhow!("could not get the latest changes"))?,
branch,
)?
} else {

View File

@@ -330,7 +330,7 @@ impl RemoteGitEngine for GiteaClient {
base: base.into(),
body: body.into(),
head: "cuddle-please/release".into(),
title: format!("chore(release): {}", version),
title: format!("chore(release): v{}", version),
};
tracing::trace!(
@@ -377,7 +377,7 @@ impl RemoteGitEngine for GiteaClient {
let request = CreatePullRequestOption {
body: body.into(),
title: format!("chore(release): {}", version),
title: format!("chore(release): v{}", version),
};
tracing::trace!(
@@ -429,9 +429,9 @@ impl RemoteGitEngine for GiteaClient {
let request = CreateReleaseOption {
body: body.into(),
draft: false,
name: version.into(),
name: format!("v{version}"),
prerelease,
tag_name: version.into(),
tag_name: format!("v{version}"),
};
tracing::trace!(