Merge pull request #1 from jodhi/no-hardcoded-ip

No hardcoded ip

agents.tf

@@ -12,7 +12,6 @@ module "agents" {
   placement_group_id     = hcloud_placement_group.k3s.id
   location               = var.location
   network_id             = hcloud_network.k3s.id
-  ip                     = cidrhost(hcloud_network_subnet.k3s.ip_range, 513 + each.value.index)
   server_type            = each.value.server_type
 
   labels = {
@@ -45,7 +44,7 @@ resource "null_resource" "agents" {
       token         = random_password.k3s_token.result
       kubelet-arg   = "cloud-provider=external"
       flannel-iface = "eth1"
-      node-ip       = cidrhost(hcloud_network_subnet.k3s.ip_range, 513 + each.value.index)
+      node-ip       = module.agents[each.key].ipv4_address
       node-label    = var.automatically_upgrade_k3s ? ["k3s_upgrade=true"] : []
     })
     destination = "/tmp/config.yaml"

locals.tf

@@ -33,7 +33,7 @@ locals {
 
   agent_nodepools = merge([
     for nodepool_name, nodepool_obj in var.agent_nodepools : {
-      for index in range(nodepool_obj.count) :
+      for index in range(lookup(nodepool_obj, "count", var.agents_num)) :
       format("%s-%s", nodepool_name, index) => {
         index : index, # just for the compatibility with previous structure
         server_type : nodepool_obj.server_type

modules/host/main.tf

@@ -14,7 +14,7 @@ resource "hcloud_server" "server" {
 
   network {
     network_id = var.network_id
-    ip         = var.ip
+    ip         = try(var.ip, null)
   }
 
   connection {

modules/host/variables.tf

@@ -60,6 +60,7 @@ variable "network_id" {
 }
 
 variable "ip" {
+  default     = null
   description = "The IP"
   type        = string
   nullable    = true

servers.tf

@@ -12,7 +12,6 @@ module "control_planes" {
   placement_group_id     = hcloud_placement_group.k3s.id
   location               = var.location
   network_id             = hcloud_network.k3s.id
-  ip                     = cidrhost(hcloud_network_subnet.k3s.ip_range, 257 + count.index)
   server_type            = var.control_plane_server_type
 
   labels = {

terraform.tfvars.example

@@ -16,16 +16,16 @@ lb_server_type            = "lb11"
 servers_num               = 3
 
 # For agent nodes, at least 2 is recommended for HA, but you can keep automatic upgrades.
+agents_num = 2
+
 agent_nodepools = {
   big = {
     server_type = "cpx31",
-    count       = 3
+    count       = 1
+  }
+  small = {
+    server_type = "cpx21",
   }
-  # Will fail because of the ip address collision (we use index number)
-  # small = {
-  #   server_type = "cpx31",
-  #   count       = 3
-  # }
 }
 
 # If you want to use a specific Hetzner CCM and CSI version, set them below, otherwise leave as is for the latest versions

variables.tf

@@ -52,12 +52,14 @@ variable "servers_num" {
   type        = number
 }
 
+variable "agents_num" {
+  description = "Default agent server type"
+  type        = number
+}
+
 variable "agent_nodepools" {
   description = "Number of agent nodes."
-  type = map(object({
-    server_type = string
-    count       = number
-  }))
+  type        = map(any)
 }
 
 variable "hetzner_ccm_version" {