rhai/src/func
Nathan Kent 86d86a85e4 Remove unsound casting functions
The casting functions in `unsafe.rs` were unsound (i.e., they allowed
safe code to cause undefined behavior). While they did appear to be used
in a way that wouldn't cause UB the fact that there exists unsound
functions is unsettling.

This commit removes those functions and replaces it with a macro that
performs the same reification - the difference is that the macro call
will also include the checks which are required to prevent UB. A macro
was chosen instead of a function for two reasons:

1. A macro can keep the same code generation whereas a function would
   require going through an `Option` which has negative impacts on code
   generation (niche values cause poor DCE).
2. There exist other `unsafe` code blocks in the crate and an attempt to
   make Rhai 100% safe is completely out-of-scope for this merge
   request, so we may as well use `unsafe` in the macro.

Regarding (2) above, I may come back at a later date with a 100% safe
`reify` function but only once the other `unsafe` blocks are removed.
For posterity, said function would look something like:

```rust
fn reify<A: Any, C>(value: A) -> Option<C> {
    let mut v = Some(value);
    let v: &mut dyn Any = &mut v;
    v.downcast_mut::<Option<C>>().map(Option::take)
}
```
2022-02-05 16:29:05 -08:00
..
args.rs Reduce size of Variant trait. 2022-01-01 19:54:46 +08:00
builtin.rs Use target_family for wasm. 2022-01-12 08:12:28 +08:00
call.rs Pass level to var resolver. 2022-02-04 22:16:12 +08:00
callable_function.rs Remove Box on callback traits. 2022-01-27 23:55:32 +08:00
func.rs Use type alias 2021-12-25 23:49:14 +08:00
hashing.rs Fixup AsRef<str> vs &str. 2022-01-04 15:22:48 +08:00
mod.rs Refactor and add state to debugger. 2022-01-28 18:59:18 +08:00
native.rs Add variable definition filter. 2022-02-04 22:59:41 +08:00
plugin.rs Use type alias 2021-12-25 23:49:14 +08:00
register.rs Remove unsound casting functions 2022-02-05 16:29:05 -08:00
script.rs Improve position display. 2022-02-04 12:04:33 +08:00