12 Commits

Author SHA1 Message Date
Stephen Chung
fa8e2e638b Fix bug. 2022-02-23 15:43:27 +08:00
Stephen Chung
97a8fd3d5b Improve reify syntax. 2022-02-08 09:25:53 +08:00
Stephen Chung
becbfa8930 Fix errors. 2022-02-06 23:02:59 +08:00
Nathan Kent
86d86a85e4 Remove unsound casting functions
The casting functions in `unsafe.rs` were unsound (i.e., they allowed
safe code to cause undefined behavior). While they did appear to be used
in a way that wouldn't cause UB the fact that there exists unsound
functions is unsettling.

This commit removes those functions and replaces it with a macro that
performs the same reification - the difference is that the macro call
will also include the checks which are required to prevent UB. A macro
was chosen instead of a function for two reasons:

1. A macro can keep the same code generation whereas a function would
   require going through an `Option` which has negative impacts on code
   generation (niche values cause poor DCE).
2. There exist other `unsafe` code blocks in the crate and an attempt to
   make Rhai 100% safe is completely out-of-scope for this merge
   request, so we may as well use `unsafe` in the macro.

Regarding (2) above, I may come back at a later date with a 100% safe
`reify` function but only once the other `unsafe` blocks are removed.
For posterity, said function would look something like:

```rust
fn reify<A: Any, C>(value: A) -> Option<C> {
    let mut v = Some(value);
    let v: &mut dyn Any = &mut v;
    v.downcast_mut::<Option<C>>().map(Option::take)
}
```
2022-02-05 16:29:05 -08:00
Stephen Chung
86fc2f7bf1 Refine types display. 2022-01-17 21:51:04 +08:00
Stephen Chung
29f1328087 Simplify Dynamic::from for better inlining. 2022-01-02 20:47:03 +08:00
Stephen Chung
d60ed5a502 Reduce size of Variant trait. 2022-01-01 19:54:46 +08:00
Stephen Chung
f443e4d9f6 Fix formatting. 2021-12-27 13:30:44 +08:00
Stephen Chung
05d4c81e7a Use type alias for error. 2021-12-27 12:27:31 +08:00
Stephen Chung
01c35808cb Use type alias 2021-12-25 23:49:14 +08:00
Stephen Chung
b4756b4575 Move CallableFunction to own file. 2021-12-20 22:13:00 +08:00
Stephen Chung
64b889fb95 Restructure code base. 2021-11-13 22:36:23 +08:00