Merge in function pointer arguments.

This commit is contained in:
Stephen Chung 2020-09-28 11:01:25 +08:00
parent f92d992165
commit a1cf852bb9
2 changed files with 34 additions and 9 deletions

View File

@ -3,7 +3,7 @@
use crate::any::{Dynamic, Variant}; use crate::any::{Dynamic, Variant};
use crate::calc_fn_hash; use crate::calc_fn_hash;
use crate::engine::Engine; use crate::engine::Engine;
use crate::fn_native::{CallableFunction, FnCallArgs, IteratorFn, SendSync}; use crate::fn_native::{CallableFunction, FnCallArgs, FnPtr, IteratorFn, SendSync};
use crate::fn_register::by_value as cast_arg; use crate::fn_register::by_value as cast_arg;
use crate::parser::{FnAccess, FnAccess::Public}; use crate::parser::{FnAccess, FnAccess::Public};
use crate::result::EvalAltResult; use crate::result::EvalAltResult;
@ -1217,10 +1217,15 @@ impl Module {
/// ///
/// ### `private_namespace` parameter /// ### `private_namespace` parameter
/// ///
/// If `true`, the entire `AST` is encapsulated into each function as a private namespace, /// * If `true`, the entire `AST` is encapsulated into each function as a private namespace,
/// allowing functions to cross-call each other. /// allowing functions to cross-call each other. Functions are searched in the module's
/// private namespace, and the global namespace cannot be accessed.
/// ///
/// If `false`, each function is registered independently and cannot cross-call /// Under this scenario, if any argument is a function pointer, then the function referred
/// to by the function pointer is also _merged_ into the module's private namespace before
/// the function call, so passing simple closures to functions work as expected.
///
/// * If `false`, each function is registered independently and cannot cross-call
/// each other. Functions are searched in the global namespace. /// each other. Functions are searched in the global namespace.
/// ///
/// # Examples /// # Examples
@ -1277,11 +1282,32 @@ impl Module {
module.set_raw_fn_as_scripted( module.set_raw_fn_as_scripted(
name, name,
num_args, num_args,
move |engine: &Engine, _, args: &mut [&mut Dynamic]| { move |engine: &Engine, lib: &Module, args: &mut [&mut Dynamic]| {
// Get anonymous functions
let anon_fns: StaticVec<_> = args
.iter()
.filter(|&arg| arg.is::<FnPtr>())
.map(|arg| arg.read_lock::<FnPtr>().unwrap().get_fn_name().clone())
.collect();
let mut lib_merged;
let call_lib = if anon_fns.is_empty() {
// No anonymous functions - just pass the AST through
&ast_lib
} else {
// If there are anonymous functions, merge them in
lib_merged = ast_lib.clone();
lib_merged.merge_filtered(&lib, &mut |_, name, _| {
anon_fns.iter().find(|s| s.as_str() == name).is_some()
});
&lib_merged
};
engine engine
.call_fn_dynamic_raw( .call_fn_dynamic_raw(
&mut Scope::new(), &mut Scope::new(),
&ast_lib, call_lib,
&fn_name, &fn_name,
&mut None, &mut None,
args, args,

View File

@ -49,8 +49,7 @@ impl StaticModuleResolver {
impl StaticModuleResolver { impl StaticModuleResolver {
/// Add a module keyed by its path. /// Add a module keyed by its path.
pub fn insert<S: Into<String>>(&mut self, path: S, mut module: Module) { pub fn insert<S: Into<String>>(&mut self, path: S, module: Module) {
module.index_all_sub_modules();
self.0.insert(path.into(), module); self.0.insert(path.into(), module);
} }
/// Remove a module given its path. /// Remove a module given its path.