Unwrap error when caught.

CHANGELOG.md

@@ -14,6 +14,7 @@ Bug fixes
 * Off-by-one error in character positions after a comment line is now fixed.
 * Globally-defined constants are now encapsulated correctly inside a loaded module and no longer spill across call boundaries.
 * Type names display is fixed.
+* Exceptions thrown inside function calls now unwrap correctly when `catch`-ed.
 
 Script-breaking changes
 -----------------------
@@ -40,6 +41,7 @@ Enhancements
 * `AST` position display is improved:
   * `Expr::start_position` is added to give the beginning of the expression (not the operator's position).
   * `StmtBlock` and `Stmt::Block` now keep the position of the closing `}` as well.
+* `EvalAltResult::unwrap_inner` is added to access the base error inside multiple layers of wrappings (e.g. `EvalAltResult::ErrorInFunction`).
 
 REPL tool changes
 -----------------

src/bin/rhai-dbg.rs

@@ -1,5 +1,5 @@
 use rhai::debugger::{BreakPoint, DebuggerCommand, DebuggerEvent};
-use rhai::{Dynamic, Engine, EvalAltResult, ImmutableString, Position, Scope};
+use rhai::{Dynamic, Engine, EvalAltResult, ImmutableString, Position, Scope, INT};
 
 use std::{
     env,
@@ -553,7 +553,16 @@ fn main() {
                         ["throw"] => {
                             break Err(EvalAltResult::ErrorRuntime(Dynamic::UNIT, pos).into())
                         }
-                        ["throw", _msg, ..] => {
+                        ["throw", num] if num.trim().parse::<INT>().is_ok() => {
+                            let value = num.trim().parse::<INT>().unwrap().into();
+                            break Err(EvalAltResult::ErrorRuntime(value, pos).into());
+                        }
+                        #[cfg(not(feature = "no_float"))]
+                        ["throw", num] if num.trim().parse::<rhai::FLOAT>().is_ok() => {
+                            let value = num.trim().parse::<rhai::FLOAT>().unwrap().into();
+                            break Err(EvalAltResult::ErrorRuntime(value, pos).into());
+                        }
+                        ["throw", ..] => {
                             let msg = input.trim().splitn(2, ' ').skip(1).next().unwrap_or("");
                             break Err(EvalAltResult::ErrorRuntime(msg.trim().into(), pos).into());
                         }

src/eval/stmt.rs

@@ -715,8 +715,8 @@ impl Engine {
                     Err(err) if err.is_pseudo_error() => Err(err),
                     Err(err) if !err.is_catchable() => Err(err),
                     Err(mut err) => {
-                        let err_value = match *err {
+                        let err_value = match err.unwrap_inner() {
-                            ERR::ErrorRuntime(ref x, ..) => x.clone(),
+                            ERR::ErrorRuntime(x, ..) => x.clone(),
 
                             #[cfg(feature = "no_object")]
                             _ => {

src/types/error.rs

@@ -403,6 +403,16 @@ impl EvalAltResult {
             }
         };
     }
+    /// Unwrap this error and get the very base error.
+    #[must_use]
+    pub fn unwrap_inner(&self) -> &Self {
+        match self {
+            Self::ErrorInFunctionCall(.., err, _) | Self::ErrorInModule(.., err, _) => {
+                err.unwrap_inner()
+            }
+            _ => self,
+        }
+    }
     /// Get the [position][Position] of this error.
     #[must_use]
     pub const fn position(&self) -> Position {