From 7caf80e27ca960be1dd65684122865a128525307 Mon Sep 17 00:00:00 2001 From: Stephen Chung Date: Sat, 18 Mar 2023 09:50:50 +0800 Subject: [PATCH] Remove BP optimization. --- CHANGELOG.md | 6 ++++++ src/eval/expr.rs | 1 + src/eval/stmt.rs | 1 + 3 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d3cf23b..915645e2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ Rhai Release Notes ================== +Version 1.14.0 +============== + +The code hacks that attempt to optimize branch prediction performance are removed because benchmarks do not show any material speed improvements. + + Version 1.13.0 ============== diff --git a/src/eval/expr.rs b/src/eval/expr.rs index 2af68f55..540eb7a7 100644 --- a/src/eval/expr.rs +++ b/src/eval/expr.rs @@ -431,6 +431,7 @@ impl Engine { #[cfg(not(feature = "no_object"))] Expr::Dot(..) => self.eval_dot_index_chain(global, caches, scope, this_ptr, expr, None), + #[allow(unreachable_patterns)] _ => unreachable!("expression cannot be evaluated: {:?}", expr), } } diff --git a/src/eval/stmt.rs b/src/eval/stmt.rs index 5d247e9d..2410d036 100644 --- a/src/eval/stmt.rs +++ b/src/eval/stmt.rs @@ -946,6 +946,7 @@ impl Engine { Ok(Dynamic::UNIT) } + #[allow(unreachable_patterns)] _ => unreachable!("statement cannot be evaluated: {:?}", stmt), } }