Use tag for debugger state.

This commit is contained in:
Stephen Chung 2022-05-03 21:55:01 +08:00
parent 4f74d2f96a
commit 516f5a82a0
4 changed files with 21 additions and 41 deletions

View File

@ -60,12 +60,7 @@ fn print_current_source(
lines: &[String], lines: &[String],
window: (usize, usize), window: (usize, usize),
) { ) {
let current_source = &mut *context let current_source = &mut *context.tag_mut().write_lock::<ImmutableString>().unwrap();
.global_runtime_state_mut()
.debugger
.state_mut()
.write_lock::<ImmutableString>()
.unwrap();
let src = source.unwrap_or(""); let src = source.unwrap_or("");
if src != current_source { if src != current_source {
println!( println!(

View File

@ -249,8 +249,6 @@ impl fmt::Display for CallStackFrame {
pub struct Debugger { pub struct Debugger {
/// The current status command. /// The current status command.
pub(crate) status: DebuggerStatus, pub(crate) status: DebuggerStatus,
/// The current state.
state: Dynamic,
/// The current set of break-points. /// The current set of break-points.
break_points: Vec<BreakPoint>, break_points: Vec<BreakPoint>,
/// The current function call stack. /// The current function call stack.
@ -258,37 +256,16 @@ pub struct Debugger {
} }
impl Debugger { impl Debugger {
/// Create a new [`Debugger`] based on an [`Engine`]. /// Create a new [`Debugger`].
#[inline(always)] #[inline(always)]
#[must_use] #[must_use]
pub fn new(engine: &Engine) -> Self { pub fn new(status: DebuggerStatus) -> Self {
Self { Self {
status: if engine.debugger.is_some() { status,
DebuggerStatus::Init
} else {
DebuggerStatus::CONTINUE
},
state: if let Some((ref init, ..)) = engine.debugger {
init()
} else {
Dynamic::UNIT
},
break_points: Vec::new(), break_points: Vec::new(),
call_stack: Vec::new(), call_stack: Vec::new(),
} }
} }
/// Get a reference to the current state.
#[inline(always)]
#[must_use]
pub fn state(&self) -> &Dynamic {
&self.state
}
/// Get a mutable reference to the current state.
#[inline(always)]
#[must_use]
pub fn state_mut(&mut self) -> &mut Dynamic {
&mut self.state
}
/// Get the current call stack. /// Get the current call stack.
#[inline(always)] #[inline(always)]
#[must_use] #[must_use]

View File

@ -97,9 +97,23 @@ impl GlobalRuntimeState<'_> {
#[cfg(not(feature = "no_module"))] #[cfg(not(feature = "no_module"))]
#[cfg(not(feature = "no_function"))] #[cfg(not(feature = "no_function"))]
constants: None, constants: None,
#[cfg(not(feature = "debugging"))]
tag: Dynamic::UNIT, tag: Dynamic::UNIT,
#[cfg(feature = "debugging")] #[cfg(feature = "debugging")]
debugger: crate::eval::Debugger::new(_engine), tag: if let Some((ref init, ..)) = engine.debugger {
init()
} else {
Dynamic::UNIT
},
#[cfg(feature = "debugging")]
debugger: crate::eval::Debugger::new(if engine.debugger.is_some() {
crate::eval::DebuggerStatus::Init
} else {
crate::eval::DebuggerStatus::CONTINUE
}),
dummy: PhantomData::default(), dummy: PhantomData::default(),
} }
} }

View File

@ -56,17 +56,11 @@ fn test_debugger_state() -> Result<(), Box<EvalAltResult>> {
Dynamic::from_map(state) Dynamic::from_map(state)
}, },
|mut context, _, _, _, _| { |mut context, _, _, _, _| {
// Get global runtime state
let global = context.global_runtime_state_mut();
// Get debugger
let debugger = &mut global.debugger;
// Print debugger state - which is an object map // Print debugger state - which is an object map
println!("Current state = {}", debugger.state()); println!("Current state = {}", context.tag());
// Modify state // Modify state
let mut state = debugger.state_mut().write_lock::<Map>().unwrap(); let mut state = context.tag_mut().write_lock::<Map>().unwrap();
let hello = state.get("hello").unwrap().as_int().unwrap(); let hello = state.get("hello").unwrap().as_int().unwrap();
state.insert("hello".into(), (hello + 1).into()); state.insert("hello".into(), (hello + 1).into());
state.insert("foo".into(), true.into()); state.insert("foo".into(), true.into());