kjuulh/moq
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Fix gosec vulnerabilities: file and directory permissions (#142)

Browse Source 
- Fix G301: Poor file permissions used when creating a directory.
- Fix G306: Poor file permissions used when writing to a new file.

See https://github.com/securego/gosec#available-rules
This commit is contained in:
Isaev Ivan 2020-12-13 06:51:03 +03:00 committed by GitHub
parent 0d9680fd45
commit b052143b5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
main.go
View File

@ -90,10 +90,10 @@ func run(flags userFlags) error {
}
// create the file
err = os.MkdirAll(filepath.Dir(flags.outFile), 0755)
err = os.MkdirAll(filepath.Dir(flags.outFile), 0750)
if err != nil {
return err
}
return ioutil.WriteFile(flags.outFile, buf.Bytes(), 0644)
return ioutil.WriteFile(flags.outFile, buf.Bytes(), 0600)
}

2
pkg/moq/moq_modules_test.go
View File

@ -15,7 +15,7 @@ import (
// copy copies srcPath to destPath, dirs and files
func copy(srcPath, destPath string, item os.FileInfo) error {
if item.IsDir() {
if err := os.MkdirAll(destPath, os.FileMode(0755)); err != nil {
if err := os.MkdirAll(destPath, os.FileMode(0750)); err != nil {
return err
}
items, err := ioutil.ReadDir(srcPath)

4
pkg/moq/moq_test.go
View File

@ -385,10 +385,10 @@ func matchGoldenFile(goldenFile string, actual []byte) error {
// To update golden files, run the following:
// go test -v -run '^<Test-Name>$' github.com/matryer/moq/pkg/moq -update
if *update {
if err := os.MkdirAll(filepath.Dir(goldenFile), 0755); err != nil {
if err := os.MkdirAll(filepath.Dir(goldenFile), 0750); err != nil {
return fmt.Errorf("create dir: %s", err)
}
if err := ioutil.WriteFile(goldenFile, actual, 0644); err != nil {
if err := ioutil.WriteFile(goldenFile, actual, 0600); err != nil {
return fmt.Errorf("write: %s", err)
}