fb09e2a1c6
I had to re-run all jobs in the CI workflow at least 10 times in the past 2 days. The problem is that when one jobs fails, all jobs need to re-run, which sometimes results in different jobs failing. It would be great if we could only re-run the jobs that failed, rather than all the jobs in the CI workflow. Going forward, we should focus on improving flaky tests, and speed the jobs which take the longest, but for now this is a good start. Before this change, we were wasting a lot of dev time - 2h in total for my last PR #1476 - but also wasting CI minutes. Some of us were even tempted to ignore CI 😱. This is a very slipper slope, and while it may feel liberating in the short-term, there are many "windmill monsters" down this path - don't do it. Have a look at the CI workflow before this change to see how many failures we had: https://github.com/dagger/dagger/actions/workflows/ci.yml Without looking at the jobs that failed, can you guess which areas are the flakiest and need our attention the most? Integration & Universe are good guesses, and I wish we could see this without digging into the CI workflow - this change does that. There is a lot more that can be improved here, but I didn't want to get too carried away. The biggest improvement that we can make is switch this to Dagger, which has some challenges, but I definitely intend to tackle them because it feels worth it. This is good enough for now. This is a ship & show PR. If all tests pass, this is a straight merge. I am keeping it atomic so that we can revert it if we don't like it. cc @aluzzardi @talentedmrjones @jlongtine @samalba @shykes @grouville Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
56 lines
1.3 KiB
YAML
56 lines
1.3 KiB
YAML
name: Lint
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
jobs:
|
|
everything:
|
|
name: Everything
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: "Check out"
|
|
uses: actions/checkout@v2
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: "Set up go"
|
|
uses: actions/setup-go@v1
|
|
with:
|
|
go-version: 1.16
|
|
|
|
- name: "Install deps"
|
|
run: |
|
|
# Cue
|
|
export CUE_VERSION="$(grep cue ./go.mod | cut -d' ' -f2 | head -1 | sed -E 's/\.[[:digit:]]\.[[:alnum:]]+-[[:alnum:]]+$//')"
|
|
export CUE_TARBALL="cue_${CUE_VERSION}_linux_amd64.tar.gz"
|
|
echo "Installing cue version $CUE_VERSION"
|
|
curl -L https://github.com/cue-lang/cue/releases/download/${CUE_VERSION}/${CUE_TARBALL} | sudo tar zxf - -C /usr/local/bin
|
|
|
|
- name: "Lint go"
|
|
uses: golangci/golangci-lint-action@v2
|
|
with:
|
|
version: v1.39
|
|
skip-go-installation: true
|
|
args: --timeout=3m
|
|
|
|
- name: "Lint shell"
|
|
run: |
|
|
make shellcheck
|
|
|
|
- name: "Lint CUE"
|
|
run: |
|
|
make cuelint
|
|
|
|
- name: "Lint docs"
|
|
run: |
|
|
make docslint
|
|
|
|
- name: "Lint markdown"
|
|
uses: avto-dev/markdown-lint@v1
|
|
with:
|
|
config: ".markdownlint.yaml"
|
|
args: ./docs README.md
|