efa24a44a0
Before this change, if BUILDKIT_HOST was set to an invalid value that resulted in the connection of the grpc client to the server to fail, then deadlock occured waiting for the `eventsCh` to be closed. This happened because the call to the buildkit client's Build method returned an error before the provided callback was executed, which is where the `eventsCh` gets closed. This change places the creation of `eventsCh` inside the Build callback, which avoids the increment of the WaitGroup and thus the deadlock in this error path. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Testing
TL;DR
# Install dependencies
yarn install
# Install gnu parallel if needed
# macOS
brew install parallel
# Debian derivatives
# apt-get install parallel
# Install sops if needed
# macOS
brew install sops
# Run all tests
yarn test
By default, the dagger binary is expected to be found in ../cmd/dagger/dagger relative to the tests directory.
If you need to change this, pass along DAGGER_BINARY=somewhere/dagger
Run a single test
To run a single test:
make && ./tests/node_modules/.bin/bats "./tests/<TESTFILE>.bats" -f "<TESTNAME>"