Commit Graph

54 Commits

Author SHA1 Message Date
Erik Sipsma
efa24a44a0 client: fix deadlock when connect to buildkitd fails
Before this change, if BUILDKIT_HOST was set to an invalid value that
resulted in the connection of the grpc client to the server to fail,
then deadlock occured waiting for the `eventsCh` to be closed.

This happened because the call to the buildkit client's Build method
returned an error before the provided callback was executed, which is
where the `eventsCh` gets closed.

This change places the creation of `eventsCh` inside the Build callback,
which avoids the increment of the WaitGroup and thus the deadlock in
this error path.

Signed-off-by: Erik Sipsma <erik@sipsma.dev>
2022-04-07 19:34:53 -07:00
Marcos Lilljedahl
8969507db6 Add global --experimental flag to gatekeep some features
This commit adds a global --experiemntal flag so we can start
gatekeeping some features where we know beforehand that the UX will very
likely change. It also refactors the current --platform flag to be
avaiable under this experimental flag for the moment

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
2022-04-06 13:53:21 -03:00
Marcos Lilljedahl
d80acf805b Add experimental way to set a target platform when building
Add an --experimental-platform flag to the do command to allow
overriding the default auto-detected build platform until we find the
time to think about the definitive multi-platform builds UX

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
2022-04-05 18:24:14 -03:00
Marcos Lilljedahl
7ffbef33b5 Report error if FS is incorrectly handled on client filesystem read
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
2022-04-01 13:25:58 -03:00
Marcos Lilljedahl
66153c6194 Prevents files to be used as input of dagger.#FS
Errors out in the PreRun phase of the clientfilesystemreader task since
otherwise, dagger execution would hang
Fixes #1977

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
2022-03-31 19:33:18 -03:00
Tom Chauveau
19c0f999f4
Fix export cache issue
Resolve #1551 and #1020.
We are never returning the result of solved operations so Buildkit could not
cache the layer.
This commit implements a simple system to forward operations' result to the
main build to cache it.

Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
2022-03-31 20:36:50 +02:00
Helder Correia
d771699df9
Move connecting socket to client: network
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-03-28 18:16:07 +00:00
Helder Correia
b3bdd347e7
Move core actions to a subpackage
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-03-27 17:33:47 +00:00
Richard Jones
770be271f1
errors on missing packages suggests project update
Signed-off-by: Richard Jones <richard@dagger.io>
2022-03-10 17:29:02 -07:00
Andrea Luzzardi
993c706faa do: simplify help management
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2022-03-10 15:11:55 -08:00
Joel Longtine
5114992a53 One more try.
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-10 15:20:36 -07:00
Joel Longtine
8b3650c08d Fix test
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-10 15:19:59 -07:00
Joel Longtine
43b9df74a8 Add test
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-10 15:15:50 -07:00
Andrea Luzzardi
05cc2adec5
Merge pull request #1740 from talentedmrjones/remove-up-command
removes dagger up in favor of dagger do
2022-03-10 10:21:48 -08:00
Richard Jones
6b81dc439d
removed dagger up in favor of dagger do
Signed-off-by: Richard Jones <richard@dagger.io>
2022-03-09 14:00:45 -07:00
Helder Correia
34b6c289dd
Remove path based task lookup
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-03-09 11:29:26 -01:00
Andrea Luzzardi
9f2d56f3c4 do: verify the action exists before running
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2022-03-08 18:34:47 -08:00
Andrea Luzzardi
f72dde1d0d
Merge pull request #1704 from helderco/inputs-outputs-cleanup
Inputs/outputs cleanup
2022-03-08 16:16:15 -08:00
Helder Correia
24d3f82fc7
Cleanup inputs, outputs and proxy
Superceded by Client API.

Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-03-08 20:45:28 -01:00
Joel Longtine
baeb19bfe2 Fix refute
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-08 13:06:22 -07:00
Joel Longtine
58dd2ab1d3 outputs -> client
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-08 13:06:22 -07:00
Joel Longtine
c9f9fd66d7 do -> "do"
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-08 13:06:22 -07:00
Joel Longtine
cf2538e1b2 Clean up tests
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-08 13:06:22 -07:00
Joel Longtine
5afaedc9ab Add do tests
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-03-08 13:06:22 -07:00
Helder Correia
da90baa087
Add new Client API
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-03-07 17:13:16 -01:00
Richard Jones
6cdf13223c
implements dagger do
Signed-off-by: Richard Jones <richard@dagger.io>
2022-03-01 13:01:26 -07:00
dubo-dubon-duponey
30b5db0586
Fix flaky tests
Signed-off-by: dubo-dubon-duponey <dubodubonduponey+github@pm.me>
2022-02-24 23:01:33 -08:00
Joel Longtine
70c0f362ea Update plan tests to use Europa constructs
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-02-23 12:20:01 -07:00
Joel Longtine
0ddd64f985 Remove --europa flag from tests
Signed-off-by: Joel Longtine <joel@dagger.io>
2022-02-23 12:20:01 -07:00
Helder Correia
813a476e06
Add outputs.files task to plan
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
2022-01-31 20:53:54 -01:00
Richard Jones
9180878cf1
fix test
Signed-off-by: Richard Jones <richard@dagger.io>
2022-01-12 10:25:56 -07:00
Richard Jones
95542d29cb
returning stderr
Signed-off-by: Richard Jones <richard@dagger.io>
2022-01-12 10:25:56 -07:00
Richard Jones
4e27937ccc
refactored tests and added more
Signed-off-by: Richard Jones <richard@dagger.io>
2022-01-04 12:20:01 -07:00
Richard Jones
7292d62cd6
more tests
Signed-off-by: Richard Jones <richard@dagger.io>
2022-01-04 11:32:26 -07:00
Richard Jones
6f4a5a769c
initial test
Signed-off-by: Richard Jones <richard@dagger.io>
2022-01-04 10:25:32 -07:00
Andrea Luzzardi
2982a0dda0 engine: Task PreRun Hook
Tasks now have a PreRun hook that gets called before buildkit kicks in.
Allows to support local access without special casing.

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2021-12-24 00:59:49 +01:00
Andrea Luzzardi
9c81a155c9 engine: Make paths relative to the CUE file they're defined in
Fixes #1309

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2021-12-23 13:48:47 -08:00
Vasek - Tom C
01414f80c9
Add tests on plan platform configuration
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
2021-12-23 15:47:11 +01:00
Andrea Luzzardi
2f1f055141 engine: Support plan outputs
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2021-12-22 15:03:54 +01:00
Richard Jones
a5568775ae
fixed linting issue
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-20 10:19:21 -07:00
Richard Jones
5ef138fe84 secret exec
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-20 09:20:19 -07:00
Richard Jones
aa268561bc
fixes issue where dagger hands when input directory does not exist
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-17 13:37:20 -07:00
Richard Jones
03a740ff1e
input to inputs
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-17 12:30:35 -07:00
Richard Jones
73e12296d3
added new test for input directories
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-17 12:30:35 -07:00
Richard Jones
c422512155 fixed test, and added more failure modes
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-15 10:22:38 -07:00
Richard Jones
a78b84429d refactored to follow the original stream test
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-15 10:22:38 -07:00
Richard Jones
94ed741320 cleanup container after test
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-15 10:22:38 -07:00
Richard Jones
2569e76eeb implemented services unix and npipe complete with test
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-15 10:22:38 -07:00
Richard Jones
33db6ab90a
using "$DAGGER"
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-10 11:02:34 -07:00
Richard Jones
518d76cbe2
previous cd fixed cue loading but broke reference to dagger binary
Signed-off-by: Richard Jones <richard@dagger.io>
2021-12-09 15:59:48 -07:00