Commit Graph

6 Commits

Author SHA1 Message Date
Andrea Luzzardi
162949d87d ci: lint dagger using dagger
- `Makefile` now uses `dagger do lint` to lint
- GHA uses dagger to lint

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
2022-04-06 18:42:18 -07:00
Marcos Lilljedahl
2290641fa4 Bump golangci-lint to latest
Golint is replaced with revive since the former has been archived and
replaced with the latter.

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
2022-03-21 17:40:10 -03:00
Gerhard Lazu
15f156e8c7
Use more descriptive names for GitHub Checks
The existing checks didn't read well in the `gh` cli:

    ❯ gh pr checks
    All checks were successful
    0 failing, 7 successful, 0 skipped, and 0 pending checks

    ✓  DCO                                 https://probot.github.io/apps/dco/
    ✓  Docs                         6m37s  https://github.com/dagger/dagger/runs/5136044870?check_suite_focus=true
    ✓  Everything                   1m43s  https://github.com/dagger/dagger/runs/5136044863?check_suite_focus=true
    ✓  Integration                  4m10s  https://github.com/dagger/dagger/runs/5136044871?check_suite_focus=true
    ✓  Universe                     11m6s  https://github.com/dagger/dagger/runs/5136044860?check_suite_focus=true
    ✓  Universe - Europa            3m18s  https://github.com/dagger/dagger/runs/5136044932?check_suite_focus=true
    ✓  netlify/devel-docs-dagge...         https://app.netlify.com/sites/devel-docs-dagger-io/deploys/620499ee88ee240008b6cabf

This change gives them more descriptive names:

    ❯ gh pr checks
    All checks were successful
    0 failing, 8 successful, 0 skipped, and 0 pending checks

    ✓  DCO                                             https://probot.github.io/apps/dco/
    ✓  Integration Tests                       4m22s   https://github.com/dagger/dagger/runs/5139842686?check_suite_focus=true
    ✓  Lint                                    1m29s   https://github.com/dagger/dagger/runs/5139842774?check_suite_focus=true
    ✓  Test Docs                               7m44s   https://github.com/dagger/dagger/runs/5139842682?check_suite_focus=true
    ✓  Unit Tests                              2m11s   https://github.com/dagger/dagger/runs/5139842684?check_suite_focus=true
    ✓  Universe Tests                          13m14s  https://github.com/dagger/dagger/runs/5139842932?check_suite_focus=true
    ✓  Universe Tests - Europa                 2m36s   https://github.com/dagger/dagger/runs/5139842678?check_suite_focus=true
    ✓  netlify/devel-docs-dagger-io/deploy...          https://deploy-preview-1593--devel-docs-dagger-io.netlify.app

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
2022-02-10 11:31:21 +00:00
Gerhard Lazu
bcd175e5eb
Use paths instead of paths-ignore for trigerring actions
Andrea made some great suggestions, thanks!

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
2022-02-04 12:18:21 +00:00
Gerhard Lazu
1b17d3b9e2
Do not run lint & tests on unrelated file changes
These paths shouldn't trigger lint or test runs.

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
2022-02-04 12:00:54 +00:00
Gerhard Lazu
fb09e2a1c6
Split CI workflow into individual workflows
I had to re-run all jobs in the CI workflow at least 10 times in the
past 2 days. The problem is that when one jobs fails, all jobs need to
re-run, which sometimes results in different jobs failing. It would be
great if we could only re-run the jobs that failed, rather than all the
jobs in the CI workflow. Going forward, we should focus on improving
flaky tests, and speed the jobs which take the longest, but for now this
is a good start.

Before this change, we were wasting a lot of dev time - 2h in total for
my last PR #1476 - but also wasting CI minutes. Some of us were even
tempted to ignore CI 😱. This is a very slipper slope, and while it may
feel liberating in the short-term, there are many "windmill monsters"
down this path - don't do it.

Have a look at the CI workflow before this change to see how many
failures we had:
https://github.com/dagger/dagger/actions/workflows/ci.yml

Without looking at the jobs that failed, can you guess which areas are
the flakiest and need our attention the most? Integration & Universe are
good guesses, and I wish we could see this without digging into the CI
workflow - this change does that.

There is a lot more that can be improved here, but I didn't want to get
too carried away. The biggest improvement that we can make is switch
this to Dagger, which has some challenges, but I definitely intend to
tackle them because it feels worth it. This is good enough for now.

This is a ship & show PR. If all tests pass, this is a straight merge. I
am keeping it atomic so that we can revert it if we don't like it.

cc @aluzzardi @talentedmrjones @jlongtine @samalba @shykes @grouville

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
2022-01-25 18:44:42 +00:00