Merge pull request #159 from verdverm/remove-local-default

Fix a source of performance degradation
This commit is contained in:
Andrea Luzzardi 2021-03-08 17:44:45 -08:00 committed by GitHub
commit ef1bb4b873
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions

View File

@ -18,7 +18,7 @@ package dagger
#Local: { #Local: {
do: "local" do: "local"
dir: string dir: string
include: [...string] | *[] include: [...string]
} }
// FIXME: bring back load (more efficient than copy) // FIXME: bring back load (more efficient than copy)

View File

@ -7,7 +7,7 @@ readonly d=$(cd "$(dirname "${BASH_SOURCE[0]:-$PWD}")" 2>/dev/null 1>&2 && pwd)
. "$d/test-lib.sh" . "$d/test-lib.sh"
# Point this to your dagger binary # Point this to your dagger binary
readonly DAGGER_BINARY="${DAGGER_BINARY:-$d/../../cmd/dagger/dagger}" readonly DAGGER_BINARY="${DAGGER_BINARY:-$d/../cmd/dagger/dagger}"
# The default arguments are a no-op, but having "anything" is a little cheat necessary for "${DAGGER_BINARY_ARGS[@]}" to not be empty down there # The default arguments are a no-op, but having "anything" is a little cheat necessary for "${DAGGER_BINARY_ARGS[@]}" to not be empty down there
DAGGER_BINARY_ARGS="${DAGGER_BINARY_ARGS:---log-format json}" DAGGER_BINARY_ARGS="${DAGGER_BINARY_ARGS:---log-format json}"
read -ra DAGGER_BINARY_ARGS <<< "${DAGGER_BINARY_ARGS:-}" read -ra DAGGER_BINARY_ARGS <<< "${DAGGER_BINARY_ARGS:-}"
@ -25,9 +25,9 @@ test::stdlib() {
test::one "stdlib: alpine" \ test::one "stdlib: alpine" \
"$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/alpine "$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/alpine
disable test::one "stdlib: yarn (FIXME: performance)" \ test::one "stdlib: yarn" \
"$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/yarn --input-dir TestData="$d"/stdlib/yarn/testdata "$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/yarn --input-dir TestData="$d"/stdlib/yarn/testdata
disable test::one "stdlib: go (FIXME: performance)" \ test::one "stdlib: go" \
"$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/go --input-dir TestData="$d"/stdlib/go/testdata "$dagger" "${DAGGER_BINARY_ARGS[@]}" compute "$d"/stdlib/go --input-dir TestData="$d"/stdlib/go/testdata
} }