kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

value.Walk: fix data race

Browse Source 
Acquire a read lock when walking through a CUE value.

Fixes #1494

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
This commit is contained in:
Andrea Luzzardi 2022-01-24 18:02:05 -08:00
parent 6ce362be5d
commit e38be1a1fc
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/value.go
View File

@ -185,7 +185,10 @@ func (v *Value) IsConcreteR(opts ...cue.Option) error {
} }
func (v *Value) Walk(before func(*Value) bool, after func(*Value)) { func (v *Value) Walk(before func(*Value) bool, after func(*Value)) {
// FIXME: lock? // FIXME: this is a long lock
v.cc.rlock()
defer v.cc.runlock()
var ( var (
llBefore func(cue.Value) bool llBefore func(cue.Value) bool
llAfter func(cue.Value) llAfter func(cue.Value)