Merge pull request #1889 from helderco/socket-rename

Rename `dagger.#Service` to `dagger.#Socket`

cmd/dagger/cmd/common/common.go

@@ -24,7 +24,7 @@ func FormatValue(val *compiler.Value) string {
 	case plancontext.IsFSValue(val):
 		return "dagger.#FS"
 	case plancontext.IsServiceValue(val):
-		return "dagger.#Service"
+		return "dagger.#Socket"
 	}
 
 	if val.IsConcreteR() != nil {

docs/drafts/plans/docker-cli-load/local.cue

@@ -7,7 +7,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: {
 		build: docker.#Build & {

docs/drafts/plans/docker-cli-run/local.cue

@@ -6,7 +6,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: run: cli.#Run & {
 		host: client.filesystem."/var/run/docker.sock".read.contents

docs/tests/core-concepts/client/plans/unix.cue

@@ -1,5 +1,5 @@
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: {
 		image: alpine.#Build & {

docs/tests/core-concepts/client/plans/windows.cue

@@ -1,6 +1,6 @@
 dagger.#Plan & {
 	client: filesystem: "//./pipe/docker_engine": read: {
-		contents: dagger.#Service
+		contents: dagger.#Socket
 		type:     "npipe"
 	}
 

pkg/dagger.io/dagger/compat.cue

@@ -0,0 +1,4 @@
+package dagger
+
+// DEPRECATED: Use #Socket instead
+#Service: #Socket

pkg/dagger.io/dagger/core/exec.cue

@@ -55,8 +55,8 @@ import "dagger.io/dagger"
 		type:     "tmp"
 		contents: #TempDir
 	} | {
-		type:     "service"
-		contents: dagger.#Service
+		type:     "socket"
+		contents: dagger.#Socket
 	} | {
 		type:     "fs"
 		contents: dagger.#FS

pkg/dagger.io/dagger/plan.cue

@@ -67,8 +67,8 @@ _#clientFilesystemRead: {
 		exclude?: [...string]
 	} | {
 		// CUE type defines expected content:
-		//     #Service: unix socket or npipe
-		contents: #Service
+		//     #Socket: unix socket or npipe
+		contents: #Socket
 
 		// Type of service
 		type: *"unix" | "npipe"

pkg/dagger.io/dagger/types.cue

@@ -26,10 +26,10 @@ package dagger
 }
 
 // A reference to a network service endpoint, for example:
-//  - A TCP or UDP port
 //  - A unix socket
+//  - A TCP or UDP port
 //  - An HTTPS endpoint
-#Service: {
+#Socket: {
 	$dagger: service: _id: string
 }
 

pkg/universe.dagger.io/docker/cli/client.cue

@@ -20,7 +20,7 @@ import (
 
 // Connect via local docker socket
 #RunSocket: {
-	host: dagger.#Service
+	host: dagger.#Socket
 
 	docker.#Run & {
 		mounts: docker: {

pkg/universe.dagger.io/docker/cli/test/load.cue

@@ -10,7 +10,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: test: {
 		_cli: alpine.#Build & {

pkg/universe.dagger.io/docker/cli/test/run.cue

@@ -8,7 +8,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: test: {
 		run: cli.#Run & {

pkg/universe.dagger.io/docker/run.cue

@@ -20,7 +20,7 @@ import (
 	// Expose network ports
 	// FIXME: investigate feasibility
 	ports: [name=string]: {
-		frontend: dagger.#Service
+		frontend: dagger.#Socket
 		backend: {
 			protocol: *"tcp" | "udp"
 			address:  string

plan/task/clientfilesystemread.go

@@ -170,7 +170,7 @@ func (t clientFilesystemReadTask) readService(pctx *plancontext.Context, v *comp
 	case "npipe":
 		npipe = path
 	default:
-		return nil, fmt.Errorf("invalid service type %q", typ)
+		return nil, fmt.Errorf("invalid socket type %q", typ)
 	}
 
 	service := pctx.Services.New(unix, npipe)

plan/task/exec.go

@@ -175,7 +175,7 @@ func (t execTask) mount(pctx *plancontext.Context, dest string, mnt *compiler.Va
 		return t.mountCache(pctx, dest, mnt)
 	case "tmp":
 		return t.mountTmp(pctx, dest, mnt)
-	case "service":
+	case "socket":
 		return t.mountService(pctx, dest, mnt)
 	case "fs":
 		return t.mountFS(pctx, dest, mnt)

tests/plan/client/filesystem/read/service/invalid.cue

@@ -6,7 +6,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.soc": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.soc": read: contents: dagger.#Socket
 
 	actions: {
 		image: core.#Pull & {

tests/plan/client/filesystem/read/service/valid.cue

@@ -6,7 +6,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: {
 		image: core.#Pull & {

tests/plan/client/filesystem/read/service/windows.cue

@@ -6,7 +6,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "//./pipe/docker_engine": read: contents: dagger.#Service
+	client: filesystem: "//./pipe/docker_engine": read: contents: dagger.#Socket
 
 	actions: {
 		image: core.#Pull & {

tests/tasks/exec/mount_service.cue

@@ -6,7 +6,7 @@ import (
 )
 
 dagger.#Plan & {
-	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Service
+	client: filesystem: "/var/run/docker.sock": read: contents: dagger.#Socket
 
 	actions: {
 		image: core.#Pull & {