kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

Merge pull request #1495 from aluzzardi/fix-data-race

Browse Source 
value.Walk: fix data race
This commit is contained in:
Andrea Luzzardi 2022-01-25 17:21:38 -08:00 committed by GitHub
commit c6d4ffb75e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/value.go
View File

@ -185,7 +185,10 @@ func (v *Value) IsConcreteR(opts ...cue.Option) error {
}
func (v *Value) Walk(before func(*Value) bool, after func(*Value)) {
// FIXME: lock?
// FIXME: this is a long lock
v.cc.rlock()
defer v.cc.runlock()
var (
llBefore func(cue.Value) bool
llAfter func(cue.Value)