kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

component: stop mixing pointers and non pointers

Browse Source 
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
This commit is contained in:
Andrea Luzzardi 2021-01-11 18:05:52 -08:00
parent fedd85f09d
commit c093a38d95
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dagger/component.go
View File

@ -14,7 +14,7 @@ func (c *Component) Value() *Value {
func (c *Component) Exists() bool { func (c *Component) Exists() bool {
// Does #dagger exist? // Does #dagger exist?
return c.Config().Err() == nil return c.Config().Exists()
} }
// Return the contents of the "#dagger" annotation. // Return the contents of the "#dagger" annotation.
@ -26,7 +26,7 @@ func (c *Component) Config() *Value {
// //
// NOTE: calling matchSpec("#Component") is not enough because // NOTE: calling matchSpec("#Component") is not enough because
// it does not match embedded scalars. // it does not match embedded scalars.
func (c Component) Validate() error { func (c *Component) Validate() error {
// FIXME: this crashes on `#dagger:compute:_` // FIXME: this crashes on `#dagger:compute:_`
// see TestValidateEmptyComponent // see TestValidateEmptyComponent
// Using a workaround for now. // Using a workaround for now.
@ -36,7 +36,7 @@ func (c Component) Validate() error {
} }
// Return this component's compute script. // Return this component's compute script.
func (c Component) ComputeScript() (*Script, error) { func (c *Component) ComputeScript() (*Script, error) {
return c.Value().Get("#dagger.compute").Script() return c.Value().Get("#dagger.compute").Script()
} }