Add Scope of Pull Requests section to the contributing guide
This is a follow-up to https://github.com/dagger/dagger/pull/1348#issuecomment-1009683510 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
This commit is contained in:
parent
c5217fc519
commit
b24bdbbe2a
@ -48,6 +48,25 @@ git rebase main # <-- this will rebase `dagger/dagger` into your `FORK/dagger`
|
|||||||
git push -f -u fork mybranch # <-- update the pull request
|
git push -f -u fork mybranch # <-- update the pull request
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Scope of Pull Requests
|
||||||
|
|
||||||
|
We prefer small incremental changes that can be reviewed and merged quickly,
|
||||||
|
with no ceremony. It's OK if it takes multiple pull requests to close an issue.
|
||||||
|
|
||||||
|
The idea is that each improvement should land in Dagger's main branch within a
|
||||||
|
few hours. The sooner we can get multiple people looking at and agreeing on a
|
||||||
|
specific change, the quicker we will have it out in a release. The quicker we
|
||||||
|
can get these small improvementes in a Dagger release, the quicker we can get
|
||||||
|
feedback from our users and find out what doesn't work, or what we have missed.
|
||||||
|
|
||||||
|
The added benefit is that this will force everyone to think about handling
|
||||||
|
partially implemented features & non-breaking changes. Both are great
|
||||||
|
approached, and they work really well in the context of Dagger.
|
||||||
|
|
||||||
|
"Small incremental changes FTW!" -> "Small pull requests that get merged within hours!"
|
||||||
|
|
||||||
|
[Original context](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531)
|
||||||
|
|
||||||
## Commits
|
## Commits
|
||||||
|
|
||||||
### DCO
|
### DCO
|
||||||
|
Reference in New Issue
Block a user