From 162e70cfd3d0cf91ea353b19883cdd2556872470 Mon Sep 17 00:00:00 2001 From: jffarge Date: Mon, 28 Mar 2022 11:54:12 +0200 Subject: [PATCH 1/4] apply comments from Emily ggdocs https://docs.google.com/document/d/1XolFtIzUMQQNOE6NNNO7JDmxECbj1uwjCcXv1SWVfeo Signed-off-by: jffarge --- docs/getting-started/1200-local-dev.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/getting-started/1200-local-dev.md b/docs/getting-started/1200-local-dev.md index 644a49a4..9f5dd2d8 100644 --- a/docs/getting-started/1200-local-dev.md +++ b/docs/getting-started/1200-local-dev.md @@ -5,8 +5,8 @@ displayed_sidebar: europa # CI/CD in your local dev -Everyone should be able to run their CI/CD pipeline locally. -Having to commit & push in order to test a change is a slow way to iterate on a pipeline. +Everyone should be able to develop, test and run their CI/CD pipeline locally. +Having to commit & push in order to test a change slows down iteration. This guide shows you the Dagger way. Within 5 minutes, you will have a local CI/CD loop and run your first test & build pipeline. From c4b16b91e1ad2dc074163372c2d303141505f305 Mon Sep 17 00:00:00 2001 From: jffarge Date: Mon, 28 Mar 2022 12:03:31 +0200 Subject: [PATCH 2/4] apply more comments Signed-off-by: jffarge --- docs/getting-started/1201-ci-environment.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/getting-started/1201-ci-environment.md b/docs/getting-started/1201-ci-environment.md index d8d2b470..9e8f0174 100644 --- a/docs/getting-started/1201-ci-environment.md +++ b/docs/getting-started/1201-ci-environment.md @@ -3,11 +3,11 @@ slug: /1201/ci-environment displayed_sidebar: europa --- -# From local dev to CI environment +# Integrating with your CI environment -Dagger can be used with any CI environment (no migration required) and has two important advantages which make the overall experience less error-prone and more efficient: +Dagger can be used with any CI environment (no migration required) and has two important advantages which make the overall experience less error-prone and more efficient: -1. Instead of YAML, you write [CUE](https://cuelang.org/) - typed configuration with built-in formatting +1. You don't write YAML [CUE](https://cuelang.org/) - typed configuration with built-in formatting 2. Configuration is executed in [BuildKit](https://github.com/moby/buildkit), the execution engine at the heart of Docker This makes any CI environment with Docker pre-installed work with Dagger out of the box. @@ -33,6 +33,7 @@ values={[ ```yaml file=../tests/getting-started/github-actions.yml title=".github/workflows/todoapp.yml" + ``` From d7ddf315d940df0ceabe94fbe05830353e79d34c Mon Sep 17 00:00:00 2001 From: jffarge Date: Mon, 28 Mar 2022 12:05:15 +0200 Subject: [PATCH 3/4] remove unecessary comment. Instead use Github review Signed-off-by: jffarge --- docs/getting-started/1201-ci-environment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-started/1201-ci-environment.md b/docs/getting-started/1201-ci-environment.md index 9e8f0174..91491e81 100644 --- a/docs/getting-started/1201-ci-environment.md +++ b/docs/getting-started/1201-ci-environment.md @@ -5,7 +5,7 @@ displayed_sidebar: europa # Integrating with your CI environment -Dagger can be used with any CI environment (no migration required) and has two important advantages which make the overall experience less error-prone and more efficient: +Dagger can be used with any CI environment (no migration required) and has two important advantages which make the overall experience less error-prone and more efficient: 1. You don't write YAML [CUE](https://cuelang.org/) - typed configuration with built-in formatting 2. Configuration is executed in [BuildKit](https://github.com/moby/buildkit), the execution engine at the heart of Docker From 8af0bb784742aa711bce1a4e1e015ac600bdcea9 Mon Sep 17 00:00:00 2001 From: jffarge Date: Tue, 29 Mar 2022 12:36:48 +0200 Subject: [PATCH 4/4] make sentence clearer Signed-off-by: jffarge --- docs/getting-started/1201-ci-environment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-started/1201-ci-environment.md b/docs/getting-started/1201-ci-environment.md index 91491e81..6c72b15a 100644 --- a/docs/getting-started/1201-ci-environment.md +++ b/docs/getting-started/1201-ci-environment.md @@ -7,7 +7,7 @@ displayed_sidebar: europa Dagger can be used with any CI environment (no migration required) and has two important advantages which make the overall experience less error-prone and more efficient: -1. You don't write YAML [CUE](https://cuelang.org/) - typed configuration with built-in formatting +1. You don't write YAML, you write [CUE](https://cuelang.org/) - typed configuration with built-in formatting 2. Configuration is executed in [BuildKit](https://github.com/moby/buildkit), the execution engine at the heart of Docker This makes any CI environment with Docker pre-installed work with Dagger out of the box.