From b24bdbbe2aab75183f59a3df75fcc77860e55e3c Mon Sep 17 00:00:00 2001 From: Gerhard Lazu Date: Tue, 11 Jan 2022 15:23:49 +0000 Subject: [PATCH 1/3] Add Scope of Pull Requests section to the contributing guide This is a follow-up to https://github.com/dagger/dagger/pull/1348#issuecomment-1009683510 Signed-off-by: Gerhard Lazu --- CONTRIBUTING.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bda8cfd9..ad892c93 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -48,6 +48,25 @@ git rebase main # <-- this will rebase `dagger/dagger` into your `FORK/dagger` git push -f -u fork mybranch # <-- update the pull request ``` +## Scope of Pull Requests + +We prefer small incremental changes that can be reviewed and merged quickly, +with no ceremony. It's OK if it takes multiple pull requests to close an issue. + +The idea is that each improvement should land in Dagger's main branch within a +few hours. The sooner we can get multiple people looking at and agreeing on a +specific change, the quicker we will have it out in a release. The quicker we +can get these small improvementes in a Dagger release, the quicker we can get +feedback from our users and find out what doesn't work, or what we have missed. + +The added benefit is that this will force everyone to think about handling +partially implemented features & non-breaking changes. Both are great +approached, and they work really well in the context of Dagger. + +"Small incremental changes FTW!" -> "Small pull requests that get merged within hours!" + +[Original context](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531) + ## Commits ### DCO From 25e4e1de1b102eac0c644eb4f5cb97ea620914cb Mon Sep 17 00:00:00 2001 From: Gerhard Lazu Date: Tue, 11 Jan 2022 15:26:16 +0000 Subject: [PATCH 2/3] Make the first line shorter & link better Signed-off-by: Gerhard Lazu --- CONTRIBUTING.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ad892c93..3f6ee2e0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,8 +50,8 @@ git push -f -u fork mybranch # <-- update the pull request ## Scope of Pull Requests -We prefer small incremental changes that can be reviewed and merged quickly, -with no ceremony. It's OK if it takes multiple pull requests to close an issue. +We prefer small incremental changes that can be reviewed and merged quickly. +It's OK if it takes multiple pull requests to close an issue. The idea is that each improvement should land in Dagger's main branch within a few hours. The sooner we can get multiple people looking at and agreeing on a @@ -63,9 +63,7 @@ The added benefit is that this will force everyone to think about handling partially implemented features & non-breaking changes. Both are great approached, and they work really well in the context of Dagger. -"Small incremental changes FTW!" -> "Small pull requests that get merged within hours!" - -[Original context](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531) +["Small incremental changes FTW!"](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531) -> "Small pull requests that get merged within hours!" ## Commits From 5e0393098112b76c5662d9b9eb6fb0c42e4839d1 Mon Sep 17 00:00:00 2001 From: Gerhard Lazu Date: Tue, 11 Jan 2022 15:28:32 +0000 Subject: [PATCH 3/3] Fix quote & remove second quote - it's not a quote Signed-off-by: Gerhard Lazu --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f6ee2e0..a0bbd3fe 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,7 +63,7 @@ The added benefit is that this will force everyone to think about handling partially implemented features & non-breaking changes. Both are great approached, and they work really well in the context of Dagger. -["Small incremental changes FTW!"](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531) -> "Small pull requests that get merged within hours!" +["Small incremental changes ftw"](https://github.com/dagger/dagger/pull/1348#issuecomment-1009628531) -> Small pull requests that get merged within hours! ## Commits