From 80e1208474be517eb7a9d5619b4f2b07b6a82063 Mon Sep 17 00:00:00 2001
From: Sam Alba <sam.alba@gmail.com>
Date: Thu, 27 May 2021 18:46:54 +0200
Subject: [PATCH] cmd/up: added support for checking for user inputs
 concreteness before the running the config

Signed-off-by: Sam Alba <sam.alba@gmail.com>
---
 cmd/dagger/cmd/input/list.go |  5 ++-
 cmd/dagger/cmd/up.go         | 60 ++++++++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+), 1 deletion(-)

diff --git a/cmd/dagger/cmd/input/list.go b/cmd/dagger/cmd/input/list.go
index 277faf0a..aae85878 100644
--- a/cmd/dagger/cmd/input/list.go
+++ b/cmd/dagger/cmd/input/list.go
@@ -47,7 +47,10 @@ var listCmd = &cobra.Command{
 		}
 
 		_, err = c.Do(ctx, st, func(ctx context.Context, env *environment.Environment, s solver.Solver) error {
-			inputs := env.ScanInputs(ctx)
+			inputs, err := env.ScanInputs(ctx, false)
+			if err != nil {
+				return err
+			}
 
 			w := tabwriter.NewWriter(os.Stdout, 0, 4, 2, ' ', 0)
 			fmt.Fprintln(w, "Input\tType\tValue\tSet by user\tDescription")
diff --git a/cmd/dagger/cmd/up.go b/cmd/dagger/cmd/up.go
index bd4d72a9..4d26a695 100644
--- a/cmd/dagger/cmd/up.go
+++ b/cmd/dagger/cmd/up.go
@@ -1,9 +1,20 @@
 package cmd
 
 import (
+	"context"
+	"os"
+
+	"cuelang.org/go/cue"
+	"go.dagger.io/dagger/client"
 	"go.dagger.io/dagger/cmd/dagger/cmd/common"
 	"go.dagger.io/dagger/cmd/dagger/logger"
+	"go.dagger.io/dagger/compiler"
+	"go.dagger.io/dagger/environment"
+	"go.dagger.io/dagger/solver"
+	"go.dagger.io/dagger/state"
+	"golang.org/x/term"
 
+	"github.com/rs/zerolog/log"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 )
@@ -25,6 +36,10 @@ var upCmd = &cobra.Command{
 
 		workspace := common.CurrentWorkspace(ctx)
 		st := common.CurrentEnvironmentState(ctx, workspace)
+
+		// check that all inputs are set
+		checkInputs(ctx, st)
+
 		result := common.EnvironmentUp(ctx, st, viper.GetBool("no-cache"))
 
 		st.Computed = result.Computed().JSON().PrettyString()
@@ -34,8 +49,53 @@ var upCmd = &cobra.Command{
 	},
 }
 
+func checkInputs(ctx context.Context, st *state.State) {
+	lg := log.Ctx(ctx)
+	warnOnly := viper.GetBool("force") || !term.IsTerminal(int(os.Stdout.Fd()))
+
+	// FIXME: find a way to merge this with the EnvironmentUp client to avoid
+	// creating the client + solver twice
+	c, err := client.New(ctx, "", false)
+	if err != nil {
+		lg.Fatal().Err(err).Msg("unable to create client")
+	}
+
+	notConcreteInputs := []*compiler.Value{}
+	_, err = c.Do(ctx, st, func(ctx context.Context, env *environment.Environment, s solver.Solver) error {
+		inputs, err := env.ScanInputs(ctx, true)
+		if err != nil {
+			return err
+		}
+
+		for _, i := range inputs {
+			if i.IsConcreteR(cue.Optional(true)) != nil {
+				notConcreteInputs = append(notConcreteInputs, i)
+			}
+		}
+
+		return nil
+	})
+
+	if err != nil {
+		lg.Fatal().Err(err).Msg("failed to query environment")
+	}
+
+	for _, i := range notConcreteInputs {
+		if warnOnly {
+			lg.Warn().Str("input", i.Path().String()).Msg("required input is missing")
+		} else {
+			lg.Error().Str("input", i.Path().String()).Msg("required input is missing")
+		}
+	}
+
+	if !warnOnly && len(notConcreteInputs) > 0 {
+		lg.Fatal().Int("missing", len(notConcreteInputs)).Msg("some required inputs are not set, please re-run with `--force` if you think it's a mistake")
+	}
+}
+
 func init() {
 	upCmd.Flags().Bool("no-cache", false, "Disable all run cache")
+	upCmd.Flags().BoolP("force", "f", false, "Force up, disable inputs check")
 
 	if err := viper.BindPFlags(upCmd.Flags()); err != nil {
 		panic(err)