kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

Report error if FS is incorrectly handled on client filesystem read

Browse Source 
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
This commit is contained in:
Marcos Lilljedahl
2022-04-01 13:00:41 -03:00
parent 66153c6194
commit 7ffbef33b5
4 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plan/task/clientfilesystemread.go
View File

@@ -26,10 +26,15 @@ func (t clientFilesystemReadTask) PreRun(_ context.Context, pctx *plancontext.Co
return err
}
if pi, err := os.Stat(path); errors.Is(err, os.ErrNotExist) {
isFS := plancontext.IsFSValue(v.Lookup("contents"))
switch pi, err := os.Stat(path); {
case errors.Is(err, os.ErrNotExist):
return fmt.Errorf("path %q does not exist", path)
} else if !pi.IsDir() && plancontext.IsFSValue(v.Lookup("contents")) {
case !pi.IsDir() && isFS:
return fmt.Errorf("path %q is not a directory", path)
case pi.IsDir() && !isFS:
return fmt.Errorf("path %q cannot be a directory", path)
}
if plancontext.IsFSValue(v.Lookup("contents")) {