Also release in the Trigger Release workflow

The first implementation of the trigger-release would not push a tag,
meaning that the Release workflow was not getting triggered. While we
could have changed the Release workflow to react on "Trigger Release"
workflow runs, the inter-dependency felt awkward and brittle:

    diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
    index b711c5cf..843fdb70 100644
    --- a/.github/workflows/release.yml
    +++ b/.github/workflows/release.yml
    @@ -7,10 +7,16 @@ on:
       push:
         tags:
         - v*
    +  workflow_run:
    +    workflows:
    +    - "Trigger Release"
    +    types:
    +    - completed

     jobs:
       goreleaser:
         runs-on: ubuntu-latest
    +    if: ${{ github.event.workflow_run.conclusion == 'success' }}
         defaults:
           run:
             shell: bash

Instead of doing the above, introducing duplication between "Trigger
Release" and "Release" seemed simpler from a cognitive perspective. Now,
releases are produced via the Release workflow when tags are pushed, and
also when releases are triggered via "Trigger Release", now renamed to
"Auto Release".

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
This commit is contained in:
Gerhard Lazu 2022-01-18 18:55:22 +00:00
parent 455beae762
commit 59e9fae189
No known key found for this signature in database
GPG Key ID: A28DE70C9444D7A6

View File

@ -1,4 +1,4 @@
name: "Trigger Release"
name: "Auto Release"
# Only a single job with this concurrency can run at any given time
concurrency: release
@ -27,8 +27,8 @@ on:
required: false
jobs:
bump_version-tag-push:
name: "Bump version, tag & push"
bump_version-tag-release:
name: "Bump version, tag & release"
runs-on: ubuntu-latest
steps:
- name: "Check out"
@ -46,7 +46,7 @@ jobs:
running-workflow-name: "Bump version, tag & push"
allowed-conclusions: success
- name: "Tag so that a new release is triggered"
- name: "Tag so that a new release can be produced"
id: tag_version
# https://github.com/mathieudutour/github-tag-action
uses: mathieudutour/github-tag-action@v6.0
@ -64,3 +64,17 @@ jobs:
# This may be of interest when we need more control over the version bumps
# https://github.com/craig-day/compute-tag
- name: "Install Go"
uses: actions/setup-go@v2
with:
go-version: 1.16
- name: "Release"
uses: goreleaser/goreleaser-action@v2
with:
args: release --rm-dist --debug
env:
GITHUB_TOKEN: ${{ secrets.DAGGERCI_TOKEN }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_REGION: us-east-1