From f0b4db8d2cac68ae88b8caf2d02ba35611d42226 Mon Sep 17 00:00:00 2001 From: jffarge Date: Fri, 25 Jun 2021 18:24:25 +0200 Subject: [PATCH] docs: :bug: rewrite useEffect + use location props Signed-off-by: jffarge --- website/src/theme/DocPage/index.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/website/src/theme/DocPage/index.js b/website/src/theme/DocPage/index.js index 3eebf60d..4d1d6ac2 100644 --- a/website/src/theme/DocPage/index.js +++ b/website/src/theme/DocPage/index.js @@ -148,17 +148,16 @@ function DocPage(props) { if (typeof window !== "undefined") return JSON.parse(window.localStorage.getItem('user')) })()) - useEffect(async () => { if (!isEmpty(authQuery) && userAccessStatus === null) { //callback after successful auth with github const user = await checkUserCollaboratorStatus(authQuery.code); if (user?.permission) { - setUserAccessStatus(user?.permission) + setUserAccessStatus(user) if (typeof window !== "undefined") window.localStorage.setItem('user', JSON.stringify(user)); } } setIsLoading(false) - }, [userAccessStatus]) + }, []) useEffect(() => { import('amplitude-js').then(amplitude => { @@ -166,10 +165,10 @@ function DocPage(props) { var amplitudeInstance = amplitude.getInstance().init(process.env.REACT_APP_AMPLITUDE_ID, userAccessStatus?.login.toLowerCase(), { apiEndpoint: `${window.location.hostname}/t` }); - amplitude.getInstance().logEvent('Docs Viewed', { "hostname": window.location.hostname, "path": window.location.pathname }); + amplitude.getInstance().logEvent('Docs Viewed', { "hostname": window.location.hostname, "path": location.pathname }); } }) - }, [(typeof window !== "undefined" && window.location.pathname)]) + }, [location.pathname, userAccessStatus]) if (isLoading) return