kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

Merge pull request #859 from TomChv/fix-typo-contributing

Browse Source 
Fix typo in CONTRIBUTING.md
This commit is contained in:
Andrea Luzzardi 2021-07-30 13:41:04 +02:00 committed by GitHub
commit 419501b7c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CONTRIBUTING.md
View File

@ -29,7 +29,7 @@ git remote add fork git@github.com:MYFORK/dagger.git
# create a branch # create a branch
git checkout -b mybranch git checkout -b mybranch
# make chances to your branch, use `git commit -s`, ... # make changes to your branch, use `git commit -s`, ...
# ... # ...
# push the branch to your own fork # push the branch to your own fork
@ -71,9 +71,8 @@ Guidelines:
- Group Commits: Each commit should represent a meaningful change (e.g. implement - Group Commits: Each commit should represent a meaningful change (e.g. implement
feature X, fix bug Y, ...). feature X, fix bug Y, ...).
- For instance, a PR should not look like _1) Add Feature X 2) Fix Typo 3) Changes to features X 5) Bugfix for feature X 6) Fix Linter 7) ..._ - For instance, a PR should not look like _1) Add Feature X 2) Fix Typo 3) Changes to features X 5) Bugfix for feature X 6) Fix Linter 7) ..._<br>
- Instead, these commits should be squashed together into a single "Add Feature" Instead, these commits should be squashed together into a single "Add Feature" commit.
commit.
- Each commit should work on its own: it must compile, pass the linter and so on. - Each commit should work on its own: it must compile, pass the linter and so on.
- This makes life much easier when using `git log`, `git blame`, `git bisect`, etc. - This makes life much easier when using `git log`, `git blame`, `git bisect`, etc.
- For instance, when doing a `git blame` on a file to figure out why a change - For instance, when doing a `git blame` on a file to figure out why a change