From 2b22d1c981d405e7d59b91f4ce055532f8512c4f Mon Sep 17 00:00:00 2001 From: Andrea Luzzardi Date: Thu, 9 Dec 2021 14:17:19 -0500 Subject: [PATCH] plan: improve log messages Signed-off-by: Andrea Luzzardi --- plan/plan.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/plan/plan.go b/plan/plan.go index b5c295a5..483afe7d 100644 --- a/plan/plan.go +++ b/plan/plan.go @@ -24,8 +24,9 @@ type Plan struct { } func Load(ctx context.Context, args ...string) (*Plan, error) { - // FIXME: universe vendoring + log.Ctx(ctx).Debug().Interface("args", args).Msg("loading plan") + // FIXME: universe vendoring if err := state.VendorUniverse(ctx, ""); err != nil { return nil, err } @@ -121,7 +122,7 @@ func newRunner(pctx *plancontext.Context, s solver.Solver, computed *compiler.Va ctx := t.Context() lg := log.Ctx(ctx).With().Str("task", t.Path().String()).Logger() ctx = lg.WithContext(ctx) - ctx, span := otel.Tracer("dagger").Start(ctx, fmt.Sprintf("compute: %s", t.Path().String())) + ctx, span := otel.Tracer("dagger").Start(ctx, fmt.Sprintf("up: %s", t.Path().String())) defer span.End() lg.Info().Str("state", string(environment.StateComputing)).Msg(string(environment.StateComputing)) @@ -145,7 +146,7 @@ func newRunner(pctx *plancontext.Context, s solver.Solver, computed *compiler.Va lg.Info().Dur("duration", time.Since(start)).Str("state", string(environment.StateCompleted)).Msg(string(environment.StateCompleted)) - // If the result is not concrete, there's nothing to merge. + // If the result is not concrete (e.g. empty value), there's nothing to merge. if !result.IsConcrete() { return nil }