Apply Solomon comments on universe.dagger.io/go

- Improve #Container with a better docker.#Run integration
- Supports concurrency caching in #Container
- Simplify code maintainability and readability
- Simplify binary export in #Build
- Support multi binary building
- External #Version management

Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>

pkg/universe.dagger.io/cue.mod/pkg/.gitignore

@@ -1,4 +1,5 @@
 # generated by dagger
 dagger.lock
 alpha.dagger.io
-universe.dagger.io
+dagger.io
+universe.dagger.io

pkg/universe.dagger.io/go/build.cue

@@ -2,14 +2,10 @@ package go
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/engine"
 )
 
 // Build a go binary
 #Build: {
-	// Go version to use
-	version: *#Image.version | string
-
 	// Source code
 	source: dagger.#FS
 
@@ -28,24 +24,27 @@ import (
 	// LDFLAGS to use for linking
 	ldflags: *"" | string
 
-	// Target binary output
-	output: string
-
 	env: [string]: string
 
-	_build: #Container & {
+	container: #Container & {
-		"version": version
+		"source": source
-		"source":  source
+		"env":    env
-		"env":     env
+		command: {
-		args: ["build", "-v", "-tags", tags, "-ldflags", ldflags, "-o", output, package]
+			args: [package]
+			flags: {
+				build:      true
+				"-v":       true
+				"-tags":    tags
+				"-ldflags": ldflags
+				"-o":       "/output/"
+			}
+		}
 	}
 
-	_copy: engine.#Copy & {
+	_binary: dagger.#Subdir & {
-		input:    engine.#Scratch
+		input: container.output.rootfs
-		contents: _build.output.rootfs
+		path:  "/output"
-		source:   output
-		dest:     output
 	}
 
-	binary: _copy.output
+	binary: _binary.output
 }

pkg/universe.dagger.io/go/container.cue

@@ -3,20 +3,21 @@ package go
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/engine"
 	"universe.dagger.io/docker"
 )
 
 // A standalone go environment to run go command
 #Container: {
 	// Go version to use
-	version: *#Image.version | string
+	version: *#DefaultVersion | string
 
 	// Source code
 	source: dagger.#FS
 
-	// Arguments
+	// Configure caching
-	args: [...string]
+	cache: {
+		id: *"go_build" | string
+	}
 
 	// Use go image
 	_image: #Image & {
@@ -29,18 +30,15 @@ import (
 	docker.#Run & {
 		input:   _image.output
 		workdir: "/src"
-		command: {
+		command: name: "go"
-			name:   "go"
-			"args": args
-		}
 		mounts: {
 			"source": {
 				dest:     _sourcePath
 				contents: source
 			}
 			"go assets cache": {
-				contents: engine.#CacheDir & {
+				contents: dagger.#CacheDir & {
-					id: "\(_cachePath)_assets"
+					id: "\(cache.id)_assets"
 				}
 				dest: _cachePath
 			}

pkg/universe.dagger.io/go/image.cue

@@ -4,9 +4,12 @@ import (
 	"universe.dagger.io/docker"
 )
 
+// Go image default version
+#DefaultVersion: "1.16"
+
 // Build a go base image
 #Image: {
-	version: *"1.16" | string
+	version: *#DefaultVersion | string
 
 	packages: [pkgName=string]: version: string | *""
 

pkg/universe.dagger.io/go/test.cue

@@ -6,6 +6,12 @@ package go
 	package: *"." | string
 
 	#Container & {
-		args: ["test", "-v", package]
+		command: {
+			args: [package]
+			flags: {
+				test: true
+				"-v": true
+			}
+		}
 	}
 }

pkg/universe.dagger.io/go/test/build.cue

@@ -2,7 +2,6 @@ package go
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/engine"
 	"universe.dagger.io/go"
 	"universe.dagger.io/docker"
 	"universe.dagger.io/alpine"
@@ -17,24 +16,23 @@ dagger.#Plan & {
 		simple: {
 			build: go.#Build & {
 				source: inputs.directories.testhello.contents
-				output: "/bin/hello"
 			}
 
 			exec: docker.#Run & {
 				input: _baseImage.output
 				command: {
 					name: "/bin/sh"
-					args: ["-c", "hello >> /output.txt"]
+					args: ["-c", "/bin/hello >> /output.txt"]
 				}
 				env: NAME: "dagger"
 				mounts: binary: {
-					dest:     build.output
+					dest:     "/bin/hello"
 					contents: build.binary
-					source:   "/bin/hello"
+					source:   "/test"
 				}
 			}
 
-			verify: engine.#ReadFile & {
+			verify: dagger.#ReadFile & {
 				input: exec.output.rootfs
 				path:  "/output.txt"
 			} & {

pkg/universe.dagger.io/go/test/container.cue

@@ -2,17 +2,16 @@ package go
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/engine"
 	"universe.dagger.io/go"
 )
 
 dagger.#Plan & {
 	actions: tests: container: {
-		_source: engine.#Scratch & {}
+		_source: dagger.#Scratch & {}
 
 		simple: go.#Container & {
 			source: _source
-			args: ["version"]
+			command: args: ["version"]
 		}
 	}
 }

pkg/universe.dagger.io/go/test/image.cue

@@ -2,14 +2,13 @@ package go
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/engine"
 	"universe.dagger.io/go"
 	"universe.dagger.io/docker"
 )
 
 dagger.#Plan & {
 	actions: tests: image: {
-		_source: engine.#Scratch & {}
+		_source: dagger.#Scratch & {}
 
 		simple: {
 			_image: go.#Image & {}