From 270d8b47756f56bc642b905381ae514850eac418 Mon Sep 17 00:00:00 2001
From: Sam Alba <sam.alba@gmail.com>
Date: Mon, 31 May 2021 15:55:44 +0200
Subject: [PATCH] cmd/output: implemented list --all

Signed-off-by: Sam Alba <sam.alba@gmail.com>
---
 cmd/dagger/cmd/output/list.go | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/cmd/dagger/cmd/output/list.go b/cmd/dagger/cmd/output/list.go
index 442f3964..5ab9c9ee 100644
--- a/cmd/dagger/cmd/output/list.go
+++ b/cmd/dagger/cmd/output/list.go
@@ -54,10 +54,15 @@ var listCmd = &cobra.Command{
 			fmt.Fprintln(w, "Output\tType\tValue\tDescription")
 
 			for _, out := range outputs {
-				isConcrete := (out.IsConcreteR() == nil)
 				valStr := "-"
-				if isConcrete {
-					valStr, _ = out.Cue().String()
+
+				if out.IsConcreteR() == nil {
+					valStr, err = out.Cue().String()
+					if err != nil {
+						return err
+					}
+				} else if !viper.GetBool("all") {
+					continue
 				}
 
 				valStr = strings.ReplaceAll(valStr, "\n", "\\n")
@@ -79,3 +84,11 @@ var listCmd = &cobra.Command{
 		}
 	},
 }
+
+func init() {
+	listCmd.Flags().BoolP("all", "a", false, "List all outputs (include non-concrete)")
+
+	if err := viper.BindPFlags(listCmd.Flags()); err != nil {
+		panic(err)
+	}
+}