fix(crate): always prefix with 'v' when creating prs, or releases (#9)
All checks were successful
continuous-integration/drone/push Build is passing

We don't want rust versions to include the 'v',

however, many languages and tools require it. As such we're choosing when to do it, in this case at the api layer.

Signed-off-by: kjuulh <contact@kjuulh.io>
Reviewed-on: #9
Co-authored-by: kjuulh <contact@kjuulh.io>
Co-committed-by: kjuulh <contact@kjuulh.io>
This commit is contained in:
Kasper Juul Hermansen 2023-08-04 12:41:31 +00:00 committed by Kasper Juul Hermansen
parent 8a8d309ddf
commit fa67dfeee3
2 changed files with 7 additions and 4 deletions

View File

@ -49,9 +49,12 @@ See docs for more information about installation and some such
### 0.3 Milestone ### 0.3 Milestone
- [ ] Fix: 0.0.0 -> **v**0.0.0
- [ ] Add release strategies
- [ ] Add reporter for PR and Repositories - [ ] Add reporter for PR and Repositories
- [ ] Add inquire for missing values when needed (when not running in ci or have a proper tty) - [ ] Add inquire for missing values when needed (when not running in ci or have a proper tty)
- [ ] Break down cuddle-please-misc - [ ] Break down cuddle-please-misc
- [ ] ci(release): Add cuddle-please release artifacts for the different os and so on.
### 0.x Milestone ### 0.x Milestone
- [ ] Add github support - [ ] Add github support

View File

@ -330,7 +330,7 @@ impl RemoteGitEngine for GiteaClient {
base: base.into(), base: base.into(),
body: body.into(), body: body.into(),
head: "cuddle-please/release".into(), head: "cuddle-please/release".into(),
title: format!("chore(release): {}", version), title: format!("chore(release): v{}", version),
}; };
tracing::trace!( tracing::trace!(
@ -377,7 +377,7 @@ impl RemoteGitEngine for GiteaClient {
let request = CreatePullRequestOption { let request = CreatePullRequestOption {
body: body.into(), body: body.into(),
title: format!("chore(release): {}", version), title: format!("chore(release): v{}", version),
}; };
tracing::trace!( tracing::trace!(
@ -429,9 +429,9 @@ impl RemoteGitEngine for GiteaClient {
let request = CreateReleaseOption { let request = CreateReleaseOption {
body: body.into(), body: body.into(),
draft: false, draft: false,
name: version.into(), name: format!("v{version}"),
prerelease, prerelease,
tag_name: version.into(), tag_name: format!("v{version}"),
}; };
tracing::trace!( tracing::trace!(